Skip to content

Codify MXC agent and code-review guidance - #1519

Open
Branden Bonaby (bbonaby) wants to merge 1 commit into
mainfrom
user/bbonaby/codify-repo-instructions
Open

Branden Bonaby (bbonaby) wants to merge 1 commit into
mainfrom
user/bbonaby/codify-repo-instructions

Conversation

@bbonaby

@bbonaby Branden Bonaby (bbonaby) commented Oct 16, 2026 •

Copy link
Copy Markdown
Collaborator

📖 Description

  • Add shared agent expectations for maintainable design, readable documentation, and meaningful functional and regression coverage.
  • Add MXC review checks for SDK breaking changes, weakened CI gates, and useful consumer-facing SDK documentation.
  • Connect Copilot, Claude, and contributor guidance to the shared rules and review skill.

Documentation and agent instructions only; no runtime or CI workflow changes.

🔗 References

No linked issue.

🔍 Validation

  • git diff --check origin/main...user/bbonaby/codify-repo-instructions — passed.
  • git rev-list --count origin/main..user/bbonaby/codify-repo-instructions — passed; one commit.
  • Runtime and SDK tests not run: documentation and agent instructions only.

✅ Checklist

📋 Issue Type

  • Bug fix
  • Feature
  • Task

GitHub Actions runs the PR validation build automatically. The ADO pipeline
(MXC-PR-Build) is the Azure version of the PR pipeline, kept in parity with the GitHub
Actions build; it runs on merge to main, and Microsoft reviewers with write access can trigger it
on a PR with /azp run. See pull request builds.

If the dependency-feed-check check fails on a new dependency, the crate must be added to
the feed before the PR can pass. See pull request builds
for the steps.

Microsoft Reviewers: Open in CodeFlow

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Copilot-Session: 1c5f0ea5-7586-4184-a1b2-e26c9ea00a2b
@bbonaby
Branden Bonaby (bbonaby) requested a review from a team as a code owner October 16, 2026 23:05
Copilot AI balanced review requested due to automatic review settings October 16, 2026 23:05
@azure-pipelines

Copy link
Copy Markdown
Azure Pipelines:
There may be pipelines that require an authorized user to comment /azp run to run.

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Approval recommended

The documentation-only changes have no identified blocking defects and require no runtime tests.

No open issues 🎉

What changed in this PR

Codifies shared development and review expectations for MXC without changing runtime behavior or CI workflows.

Changes:

  • Adds shared design, documentation, and testing guidance.
  • Defines review checks for SDK compatibility, CI coverage, and containment.
  • Connects contributor, Copilot, and Claude guidance.
File Description
CONTRIBUTING.md Clarifies testing expectations and links shared guidance.
CLAUDE.md Points Claude to shared instructions and review guidance.
AGENTS.md Defines design, communication, and validation expectations.
.github/​skills/​mxc-code-review/​SKILL.md Adds repository-specific review checks.
.github/​copilot-instructions.md Links shared engineering and review guidance.

Review effort: Balanced

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants