Decode percent-encoded data URI parameters - #2547
Open
Newman Gao (bozarnr) wants to merge 1 commit into
Open
Newman Gao (bozarnr) wants to merge 1 commit into
Newman Gao (bozarnr) wants to merge 1 commit into
Conversation
Contributor
There was a problem hiding this comment.
Copilot review overview
🟢 Approval recommended
No unresolved review issues were identified, and regression coverage is included.
Review effort: Lite
Findings: None
What changed in this PR
Updates data URI parsing to decode percent-encoded metadata parameters, including charset, before conversion.
Changes:
- Decode parameter values with
urllib.parse.unquote. - Add regression coverage for encoded charset and content values.
| File | Description |
|---|---|
packages/markitdown/tests/test_module_misc.py |
Tests percent-encoded data URI parsing. |
packages/markitdown/src/markitdown/_uri_utils.py |
Decodes data URI parameter values. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
charsetvalues so downstream stream decoding receives the declared charsetValidation
data:text/plain;charset=utf%2D8,...python -m py_compile packages/markitdown/src/markitdown/_uri_utils.py packages/markitdown/tests/test_module_misc.pygit diff --checkThe existing base64-data URI work addresses escapes in the payload. This change covers the independent metadata parameter path consumed by
MarkItDown.convert_uri().