Skip to content

Refactor duplication startup publication - #1411

Open
Weidong Cui (wdcui) wants to merge 7 commits into
uliteboxfrom
wdcui/ulitebox/duplication-startup-publication
Open

Weidong Cui (wdcui) wants to merge 7 commits into
uliteboxfrom
wdcui/ulitebox/duplication-startup-publication

Conversation

@wdcui

@wdcui Weidong Cui (wdcui) commented Sep 23, 2026

Copy link
Copy Markdown
Member

This PR makes broker process startup source-neutral, restricts production creation to a shared process-and-initial-thread path, and prepares duplication children only for parent-death behavior while every runner uses the same association activation path.

Weidong Cui (wdcui) and others added 2 commits September 23, 2026 15:30
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Copilot-Session: ee779b34-31e2-4e38-8068-21fe8fce7674
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

Copilot-Session: ee779b34-31e2-4e38-8068-21fe8fce7674
@wdcui Weidong Cui (wdcui) changed the title Complete duplication startup publication Refactor duplication startup publication Sep 24, 2026
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

Copilot-Session: ee779b34-31e2-4e38-8068-21fe8fce7674
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

Copilot-Session: ee779b34-31e2-4e38-8068-21fe8fce7674
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

Copilot-Session: ee779b34-31e2-4e38-8068-21fe8fce7674
Rename the broker lifecycle dimension to ProcessStatus and remove the cross-crate threadless test process backdoor. External tests now use the production process-and-initial-thread creation path.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

Copilot-Session: ee779b34-31e2-4e38-8068-21fe8fce7674
@github-actions

Copy link
Copy Markdown

🤖 SemverChecks 🤖 ⚠️ Potential breaking API changes detected ⚠️

Click for details
--- failure inherent_method_missing: pub method removed or renamed ---

Description:
A publicly-visible method or associated fn is no longer available under its prior name. It may have been renamed or removed entirely.
        ref: https://doc.rust-lang.org/cargo/reference/semver.html#item-remove
       impl: https://github.com/obi1kenobi/cargo-semver-checks/tree/v0.50.0/src/lints/inherent_method_missing.ron

Failed in:
  BrokerProcess::begin_duplication, previously in file /home/runner/work/litebox/litebox/target/semver-checks/git-ulitebox/e2932b81761b715e3f7f68dbe7c240fea3dc87df/litebox_broker_core/src/process.rs:548
  BrokerProcess::mark_abnormal, previously in file /home/runner/work/litebox/litebox/target/semver-checks/git-ulitebox/e2932b81761b715e3f7f68dbe7c240fea3dc87df/litebox_broker_core/src/process.rs:678
  BrokerCore::create_process, previously in file /home/runner/work/litebox/litebox/target/semver-checks/git-ulitebox/e2932b81761b715e3f7f68dbe7c240fea3dc87df/litebox_broker_core/src/lib.rs:334

--- failure struct_missing: pub struct removed or renamed ---

Description:
A publicly-visible struct cannot be imported by its prior path. A `pub use` may have been removed, or the struct itself may have been renamed or removed entirely.
        ref: https://doc.rust-lang.org/cargo/reference/semver.html#item-remove
       impl: https://github.com/obi1kenobi/cargo-semver-checks/tree/v0.50.0/src/lints/struct_missing.ron

Failed in:
  struct litebox_broker_core::BrokerThread, previously in file /home/runner/work/litebox/litebox/target/semver-checks/git-ulitebox/e2932b81761b715e3f7f68dbe7c240fea3dc87df/litebox_broker_core/src/process.rs:125
  struct litebox_broker_core::DuplicationTransaction, previously in file /home/runner/work/litebox/litebox/target/semver-checks/git-ulitebox/e2932b81761b715e3f7f68dbe7c240fea3dc87df/litebox_broker_core/src/process.rs:222

Use create_process for the complete production operation and reserve allocate_process for core-internal tests that intentionally need threadless state.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

Copilot-Session: ee779b34-31e2-4e38-8068-21fe8fce7674
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant