Verify TAs - #1399
Draft
Angelina Vu (athvu) wants to merge 5 commits into
Draft
Verify TAs#1399Angelina Vu (athvu) wants to merge 5 commits into
Angelina Vu (athvu) wants to merge 5 commits into
Conversation
added 5 commits
September 21, 2026 06:32
Signed-off-by: Angelina Vu <angelinavu@microsoft.com>
Signed-off-by: Angelina Vu <angelinavu@microsoft.com>
Dynamic TAs must be signed and verified. Signed-off-by: Angelina Vu <angelinavu@microsoft.com>
Signed-off-by: Angelina Vu <angelinavu@microsoft.com>
|
🤖 SemverChecks 🤖 No breaking API changes detected Note: this does not mean API is unchanged, or even that there are no breaking changes; simply, none of the detections triggered. |
Angelina Vu (athvu)
marked this pull request as draft
September 21, 2026 17:43
Praveen K Paladugu (praveen-pk)
assigned
Praveen K Paladugu (praveen-pk) and unassigned
Praveen K Paladugu (praveen-pk)
Contributor
|
Why make this a compile time feature: |
| } else { | ||
| let ta_bin = Self::rpc_get_ta_bin(ta_uuid)?; | ||
| if !self.store_ta_bin(ta_uuid, &ta_bin) { | ||
| if !self.store_ta_bin(ta_uuid, &ta_bin, TaSource::Dynamic) { |
Contributor
There was a problem hiding this comment.
fyi, the place to store_ta_bin changed with the open Dynamic TA Support PR (#1213).
So, this should be revisited later
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add a feature signed-ta-rsa to enable TA signature verification. A verification key can be embedded through the LITEBOX_TA_VERIFY_KEY build variable.
Built-in TAs can either be unsigned .elf or signed .ta files. Dynamic TAs must be signed.