Repository navigation
Bump SE.Redis to 3.2.0 - #2126
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
The dependency update and analyzer-driven test adjustments are consistent, targeted, and introduce no identified correctness issues.
Pull request overview
Upgrades StackExchange.Redis to 3.2.0 for fixes required by #2110 and resolves newly introduced analyzer warnings.
Changes:
- Bumps StackExchange.Redis from 2.12.8 to 3.2.0.
- Updates tests to avoid sync-over-async patterns and explicitly discard queued transaction results.
- Adds targeted suppressions where separate transaction operations are intentional.
File summaries
| File | Description |
|---|---|
Directory.Packages.props |
Updates StackExchange.Redis version. |
test/cluster/Garnet.test.cluster/ClusterTestUtils.cs |
Uses synchronous INFO APIs in synchronous helpers. |
test/standalone/Garnet.test.collections/RespHashTests.cs |
Replaces blocking waits with awaits. |
test/standalone/Garnet.test.scripting/MultiDatabaseTests.cs |
Addresses transaction analyzer warnings. |
test/standalone/Garnet.test.scripting/RespAofTests.cs |
Addresses transaction analyzer warnings. |
test/standalone/Garnet.test.scripting/TransactionTests.cs |
Addresses transaction analyzer warnings. |
Review details
- Files reviewed: 6/6 changed files
- Comments generated: 0
- Review effort level: Balanced
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
…, general permission validation, and also defaults to Resp3 now
Badrish Chandramouli (badrishc)
approved these changes
Sep 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pulling in latest SE.Redis for fixes needed in #2110.
Fixes things flagged by new analyzers, places where a DB must now be explicitly passed, and places where we were assuming RESP2 implicitly (RESP3 is now the default if SE.Redis thinks it's supported). SE.Redis also validates admin commands for
Execute(Async), so admin commands are enabled for more (but not all) tests now.See https://github.com/StackExchange/StackExchange.Redis/releases/tag/3.0.0 for the "big" changes.