Repository navigation
CI: pilot Win32 Storybook physical input without changing accessibility coverage - #4431
Open
srividyaramas wants to merge 1 commit into
Open
srividyaramas wants to merge 1 commit into
srividyaramas wants to merge 1 commit into
Conversation
Preserve the masked accessibility smoke run, select Checkbox click and Button keyboard/focus callbacks in a serial unmasked pass, and reject skipped or missing required results. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: 4b66f3ef-85ac-4405-bd35-dcc167a077b1
Contributor
Bundle size reportTree-shaken, minified production esbuild bundles with React and React Native runtimes externalized.
The job is advisory: size changes are reported but do not fail the pull request. Bundle or analysis errors still fail. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Try a small physical-input cohort on the existing GitHub-hosted Win32/Paper Storybook runner, without removing the current accessibility-mode coverage.
keyboard,physicalClick,wheeldisabled.STORYBOOK_SMOKE_TESTconfiguration entry so this pass selects exactly two existing callbacks:Storybook_win32_paper_<run>_<attempt>artifact.This PR does not change component behavior, native input implementation, runner provisioning, or macOS/Fabric policy. It does not enable all input-gated tests or remove the separate Button quarantine for #4373.
Why a separate pass?
The current mask was introduced in #4306 because hosted input was not considered authoritative. Legacy Win32 tests now use the same Desktop Driver with physical input enabled, so a focused experiment is warranted rather than assuming input cannot work.
Simply removing the mask from the existing full Storybook pass would also change automatic clicks from accessibility actions to physical input, invalidating tests that intentionally check accessibility activation. Keep those tests unchanged and qualify physical input separately.
The added pass runs as part of this PR's normal
pull_requestCI, before merge. A failed or skipped required callback is useful negative evidence; this change does not assume that hosted input is reliable.Validation
git diff --check.yarn clean-lage-cacheandyarn lage buildci, but neither could start because the installed pnpm map lacks current-main dependencies. Twoyarn install --immutableattempts (including a bounded-concurrency retry) failed with TLS handshake errors. The formatter and static discovery were run using the already-installed declared binaries to bypass the incomplete Yarn map. This is not a local aggregate pass.