Repository navigation
Expose agentic package config imports for installed dependency resolution - #4428
Merged
Patrick Boyd (PPatBoyd) merged 2 commits intoNov 2, 2026
Conversation
…rently avoided by workspace-linked dependency mechanics
Patrick Boyd (PPatBoyd)
requested review from
Jason Morse (JasonVMo)
and
a balanced review from Copilot
October 30, 2026 19:17
There was a problem hiding this comment.
🟡 Changes recommended
The published-package export changes lack a required patch changeset for both affected packages, so the installed-dependency fix is not scheduled for release.
1 open issue
What changed in this PR
This PR enables downstream consumers to import desktop testing configuration from installed packages without local loader workarounds.
Changes:
- Adds compiled JavaScript
importtargets for both packages’./configexports. - Preserves existing type declarations and TypeScript default targets.
Validation was not run during this review.
| File | Description |
|---|---|
packages/agentic/storybook-desktop/package.json |
Maps ./config imports to ./lib/config/index.js. |
packages/agentic/desktop-test/package.json |
Maps ./config imports to ./lib/config.js. |
Review effort: Balanced
Contributor
Bundle size reportTree-shaken, minified production esbuild bundles with React and React Native runtimes externalized.
The job is advisory: size changes are reported but do not fail the pull request. Bundle or analysis errors still fail. |
srividyaramas
approved these changes
Oct 30, 2026
Jason Morse (JasonVMo)
approved these changes
Nov 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Description of changes
Configs made in downstream packages consuming
desktop-testandstorybook-desktopas an installed dependency can't resolve imports without local loader workarounds, e.g.FURN internal consumption for storybook configs aren't blocked on this due to workspace-local package linking mechanics that can leverage the
"default": "./src/config.ts"directly.Verification
Verified FURN and downstream package consumption without downstream workarounds, including local running/passing of storybook smoke-e2e tests.
Pull request checklist
This PR has considered (when applicable):