Skip to content

Expose agentic package config imports for installed dependency resolution - #4428

Merged
Patrick Boyd (PPatBoyd) merged 2 commits into
microsoft:mainfrom
PPatBoyd:user/patboyd/storybookCompatChanges
Nov 2, 2026
Merged

Patrick Boyd (PPatBoyd) merged 2 commits into
microsoft:mainfrom
PPatBoyd:user/patboyd/storybookCompatChanges

Conversation

@PPatBoyd

Copy link
Copy Markdown
Contributor

Description of changes

Configs made in downstream packages consuming desktop-test and storybook-desktop as an installed dependency can't resolve imports without local loader workarounds, e.g.

import { defineDesktopConfig } from "@fluentui-react-native/desktop-test/config";

import {
  createWin32RunCommand,
  createWin32SmokeCommand,
  storybook,
} from "@fluentui-react-native/storybook-desktop/config";

FURN internal consumption for storybook configs aren't blocked on this due to workspace-local package linking mechanics that can leverage the "default": "./src/config.ts" directly.

Verification

Verified FURN and downstream package consumption without downstream workarounds, including local running/passing of storybook smoke-e2e tests.

Pull request checklist

This PR has considered (when applicable):

  • Automated Tests
  • Documentation and examples
  • Keyboard Accessibility
  • Voiceover
  • Internationalization and Right-to-left Layouts

…rently avoided by workspace-linked dependency mechanics

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟡 Changes recommended

The published-package export changes lack a required patch changeset for both affected packages, so the installed-dependency fix is not scheduled for release.

1 open issue
What changed in this PR

This PR enables downstream consumers to import desktop testing configuration from installed packages without local loader workarounds.

Changes:

  • Adds compiled JavaScript import targets for both packages’ ./config exports.
  • Preserves existing type declarations and TypeScript default targets.

Validation was not run during this review.

File Description
packages/​agentic/​storybook-desktop/​package.json Maps ./config imports to ./lib/config/index.js.
packages/​agentic/​desktop-test/​package.json Maps ./config imports to ./lib/config.js.

Review effort: Balanced

@github-actions

github-actions Bot commented Oct 30, 2026 •

Copy link
Copy Markdown
Contributor

Bundle size report

Tree-shaken, minified production esbuild bundles with React and React Native runtimes externalized.

Scenario Modules-Mac (Δ) Modules-Win (Δ) Size-Mac (Δ) Size-Win (Δ)
components-button 65 (+1) 66 (+1) 51.57k (+944b) 51.50k (+944b)
components-catalog 214 (+0) 215 (+0) 206.83k (+1.35k) 206.76k (+1.35k)
design-theme-state 34 (+0) 35 (+0) 30.15k (+0b) 30.08k (+0b)
design-themed-root 38 (+0) 39 (+0) 32.12k (+0b) 32.04k (+0b)
design-color-lib 6 (+0) 6 (+0) 6.33k (+0b) 6.33k (+0b)
design-theme-state-legacy-source 35 (+0) 36 (+0) 31.81k (+0b) 31.73k (+0b)
design-legacy-theme-from-flex 58 (+0) 59 (+0) 97.77k (+0b) 97.63k (+0b)

The job is advisory: size changes are reported but do not fail the pull request. Bundle or analysis errors still fail.


View bundle-size workflow run

@PPatBoyd
Patrick Boyd (PPatBoyd) merged commit ff3f961 into microsoft:main Nov 2, 2026
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants