Skip to content

Agentic Badge: extend rendering and accessibility regression coverage #4410

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Jason Morse (JasonVMo) merged 2 commits into from
Oct 29, 2026
Merged

Agentic Badge: extend rendering and accessibility regression coverage #4410

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
37e2a9f
test(badge): cover visibility order and semantic color matrix
SriRamas23 Oct 27, 2026
a610113
chore(badge): record test-only changeset
SriRamas23 Oct 27, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/all-parrots-look.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---

---


41 changes: 40 additions & 1 deletion packages/agentic/components/src/components/badge/badge.test.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,6 +24,39 @@ function getRootStyle(component: Awaited<ReturnType<typeof renderBadge>>): ViewS
}

describe('Badge', () => {
it('BDG-002/BDG-004 hides an unnamed default badge and renders no unsupplied trailing icon', async () => {
const component = await renderBadge({ testID: 'badge', trailingIconVisible: true });

expect(component.queryByRole('image')).toBeNull();
const root = component.getByTestId('badge', { includeHiddenElements: true });
expect(root.props).toMatchObject({
accessible: false,
accessibilityElementsHidden: true,
importantForAccessibility: 'no-hide-descendants',
focusable: false,
});
expect(component.getByText('Badge', { includeHiddenElements: true })).toBeOnTheScreen();
expect(root.children).toHaveLength(2);
});

it.each([
[false, false, ['content']],
[false, true, ['content', 'trailing-icon']],
[true, false, ['leading-icon', 'content']],
[true, true, ['leading-icon', 'content', 'trailing-icon']],
] as const)('BDG-002 preserves slot order with leading=%s and trailing=%s', async (leadingIconVisible, trailingIconVisible, order) => {
const component = await renderBadge({
accessibilityLabel: 'Status',
content: { children: 'Status', testID: 'content' },
leadingIcon: { ...badgeIcon, testID: 'leading-icon' },
trailingIcon: { ...trailingIcon, testID: 'trailing-icon' },
leadingIconVisible,
trailingIconVisible,
});

expect(getRoot(component).children.map((child) => (typeof child === 'string' ? child : child.props.testID))).toEqual(order);
});

it('renders default icon-and-text styling with forwarded icons and label', async () => {
const component = await renderBadge({
accessibilityLabel: 'Badge',
Expand Down Expand Up @@ -107,10 +140,16 @@ describe('Badge', () => {

it.each([
['tint', 'brand', 'backgroundBrandSoft', 'foregroundBrandPrimary', 'strokeNeutralTransparent', 0],
['tint', 'danger', 'backgroundDangerSoft', 'foregroundDangerPrimary', 'strokeNeutralTransparent', 0],
['tint', 'success', 'backgroundSuccessSoft', 'foregroundSuccessPrimary', 'strokeNeutralTransparent', 0],
['tint', 'warning', 'backgroundWarningSoft', 'foregroundWarningPrimary', 'strokeNeutralTransparent', 0],
['tint', 'informative', 'backgroundNeutralSoft', 'foregroundNeutralPrimary', 'strokeNeutralTransparent', 0],
['outline', 'brand', 'backgroundNeutralTransparent', 'foregroundBrandPrimary', 'strokeBrandLoud', 1],
['outline', 'danger', 'backgroundNeutralTransparent', 'foregroundDangerPrimary', 'strokeDangerLoud', 1],
['outline', 'success', 'backgroundNeutralTransparent', 'foregroundSuccessPrimary', 'strokeSuccessLoud', 1],
['outline', 'warning', 'backgroundNeutralTransparent', 'foregroundWarningPrimary', 'strokeWarningLoud', 1],
] as const)('resolves %s %s colors', async (appearance, color, backgroundToken, foregroundToken, borderToken, borderWidth) => {
['outline', 'informative', 'backgroundNeutralTransparent', 'foregroundNeutralPrimary', 'strokeNeutralLoud', 1],
] as const)('BDG-003 resolves %s %s colors', async (appearance, color, backgroundToken, foregroundToken, borderToken, borderWidth) => {
const tokens = defaultFlexTokens;
const component = await renderBadge({
accessibilityLabel: `${appearance} ${color} badge`,
Expand Down
Loading