fix(houdini-utils): generate non-clashing IDs - #591
Open
Oleksandr Fediashov (layershifter) wants to merge 1 commit into
Open
fix(houdini-utils): generate non-clashing IDs#591Oleksandr Fediashov (layershifter) wants to merge 1 commit into
Oleksandr Fediashov (layershifter) wants to merge 1 commit into
Conversation
Oleksandr Fediashov (layershifter)
force-pushed
the
fix/houdini-id-generation
branch
from
December 17, 2025 13:59
bcc7caa to
58ac7be
Compare
Oleksandr Fediashov (layershifter)
marked this pull request as ready for review
December 17, 2025 14:01
Oleksandr Fediashov (layershifter)
requested a review
from a team
as a code owner
December 17, 2025 14:01
Juraj Kapsiar (jurokapsiar)
approved these changes
Dec 17, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently DOM IDs for fallbacks could clash when the dependency is bundled multiple times due a local counter used for IDS:
fluentui-contrib/packages/houdini-utils/src/paint/fallback/fallbackPaintAnimation.ts
Line 27 in b98c65b
Would great to rely on user provided IDs, but it will be another breaking change.