Repository navigation
Fix stackable snackbar scrim accessibility - #842
Merged
Sahasra_venepally (Sab-do3) merged 1 commit intoOct 16, 2026
Merged
Sahasra_venepally (Sab-do3) merged 1 commit into
Sahasra_venepally (Sab-do3) merged 1 commit into
Conversation
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: d684a345-708c-46b9-a1e1-ae1615fd78f3
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
The two narrowly scoped accessibility changes preserve existing behavior and have no identified blocking issues.
0 open findings
What changed in this PR
Improves stackable snackbar scrim accessibility without changing click behavior.
Changes:
- Adds an explicit button role to the scrim.
- Updates the default English label to describe collapsing expanded notifications; translations remain unchanged.
| File | Description |
|---|---|
| fluentui_notification/src/main/res/values/strings.xml | Changes the default accessibility label from dismissal to collapse wording. |
| fluentui_notification/src/main/java/com/microsoft/fluentui/tokenized/notification/StackableSnackbar.kt | Adds Role.Button while preserving onDismiss. |
🧠 Review effort: Balanced
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Collaborator
Author
|
@microsoft-github-policy-service agree company="Microsoft" |
kartikeyakhanna
approved these changes
Oct 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
AI-generated
Problem
The stackable snackbar scrim lacks an explicit button role for accessibility services, and its default English accessibility label describes dismissing rather than collapsing expanded notifications.
Root cause
The scrim's clickable modifier does not specify a role, and the default
scrim_content_descriptionuses dismissal wording.Fix
role = Role.Buttonto the scrim's clickable modifier.Collapse Expanded notifications.onDismisscallback and click behavior.Dismiss Expanded notifications.Collapse Expanded notifications.