Repository navigation
considering the first snackbars height in combined height calculation - #841
Merged
Pranjal Singh (pranjal-glowingstar) merged 1 commit intoOct 6, 2026
Conversation
Contributor
There was a problem hiding this comment.
Copilot review overview
🟢 Approval recommended
The focused change correctly includes the previously omitted first snackbar.
Review effort: Balanced
Findings: None
What changed in this PR
Updates expanded snackbar stack height calculation to include the first visible snackbar.
Changes:
- Calculates total height from before index
0, preventing clipping and incorrect positioning.
| File | Description |
|---|---|
StackableSnackbar.kt |
Includes all visible snackbars in expanded stack height. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Nevil Dalsania (Nevilkumar)
approved these changes
Oct 6, 2026
Pranjal Singh (pranjal-glowingstar)
merged commit Oct 6, 2026
207ae68
into
master
5 of 6 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The expanded stackable snackbar height did not include the first snackbar, causing the combined stack height to be too small and is clipping the expanded stack.
Root cause
heightAfterIndex(0) calculates the height starting after index 0 , so the first snackbar was excluded from combinedStackHeight .
Fix
Changed the calculation to heightAfterIndex(-1) , which starts from index 0 and includes every visible snackbar in the expanded stack.
Validations
Verified that heightAfterIndex(-1) includes all visible snackbar heights.
Checked efficacy with multiple snackbars in fluent ui and Exported the aar to local word build and checked the print screen message.
Truncation issue resolved:
https://onedrive.cloud.microsoft/:i:/a@w4j39v4s/S/cQqsvXLLbRcrT6DgC4GN7GyMEgUB4ZgAhK55GzQumQCTOrlt3Q