chore: downmerge main to dev - #293
Merged
Merged
Conversation
fix: Enhance Cosmos DB firewall handling in post deployment script and address code quality issues
…sh instructions fix: remove unused trust policy status in Bicep file
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
fix: update deployment workflow to build and push images to acr, update model to gpt-5.4-mini
…QuotaCheck with quota scripts
…ere main.bicep uses it, revert local/quota docs to 4.1-mini
…tes tracked separately)
docs: update GPT model references from gpt-4.1-mini to gpt-5.4-mini
chore: Update Owners ID for Vinay and Prajwal
Harsh-Microsoft
requested review from
Avijit-Microsoft,
Roopan-Microsoft,
gpickett,
malrose07 and
Todd Herman (toherman-msft)
as code owners
July 17, 2026 05:22
Contributor
There was a problem hiding this comment.
Pull request overview
This pull request downmerges main to dev and, per the PR description, updates the solution’s default GPT model references to gpt-5.4-mini while enhancing Azure deployment guidance and infrastructure (notably adding an Azure Container Registry with private networking support). It also includes an unrelated frontend parsing adjustment in textParsers.ts.
Changes:
- Update documentation/configuration references from
gpt-4.1-minitogpt-5.4-mini(including default regions/quotas guidance). - Provision an Azure Container Registry (ACR) via
infra/main.bicepand add scripts to build/push backend/frontend images and repoint App Services post-provision. - Adjust product parsing to avoid treating the first product section as intro text when text begins with a product heading.
Reviewed changes
Copilot reviewed 14 out of 14 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| src/App/src/lib/textParsers.ts | Updates product text parsing to better detect when the first split part is a product section. |
| README.md | Updates GPT model references in solution overview/cost table. |
| infra/scripts/build_push_images.sh | Adds bash automation to build/push images in ACR and update App Services to use them. |
| infra/scripts/build_push_images.ps1 | Adds PowerShell automation to build/push images in ACR and update App Services to use them. |
| infra/main.waf.parameters.json | Removes now-unused container registry endpoint/image tag parameters from WAF parameters. |
| infra/main.parameters.json | Removes now-unused container registry endpoint/image tag parameters from parameters. |
| infra/main.bicep | Updates default GPT model/version/regions; adds ACR + private DNS; switches web apps to placeholder images pending build/push step. |
| documents/TechnicalArchitecture.md | Updates GPT model reference in architecture overview. |
| documents/QuotaCheck.md | Updates default model string and sample command to new GPT model. |
| documents/LocalDevelopmentSetup.md | Updates local env examples to use new GPT deployment name. |
| documents/DeploymentGuide.md | Updates GPT references and adds explicit post-provision container build/push step. |
| documents/CustomizingAzdParameters.md | Updates GPT defaults in the azd parameter list. |
| documents/AzureGPTQuotaSettings.md | Updates quota UI guidance to reference the new GPT model. |
| azure.yaml | Updates postprovision messaging to include the new image build/push step before data/agent setup. |
Comments suppressed due to low confidence (1)
src/App/src/lib/textParsers.ts:210
outroTextextraction is now gated behind!firstPartIsProduct, so when the text starts directly with a product section (no intro),outroTextwill never be detected even if there is trailing text after the last product image/link.
if (parts.length > 0 && !firstPartIsProduct) {
introText = parts[0].trim();
introText = introText.replace(/^###\s*[^\n]*\n?/gm, '').trim();
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Prajwal-Microsoft
had a problem deploying
to
production
July 17, 2026 05:52 — with
GitHub Actions
Failure
Avijit-Microsoft
approved these changes
Jul 17, 2026
Prajwal-Microsoft
had a problem deploying
to
production
July 17, 2026 17:24 — with
GitHub Actions
Failure
Prajwal-Microsoft
had a problem deploying
to
production
July 18, 2026 05:44 — with
GitHub Actions
Failure
Prajwal-Microsoft
had a problem deploying
to
production
July 18, 2026 17:19 — with
GitHub Actions
Failure
Prajwal-Microsoft
had a problem deploying
to
production
July 19, 2026 05:59 — with
GitHub Actions
Failure
Prajwal-Microsoft
had a problem deploying
to
production
July 19, 2026 17:20 — with
GitHub Actions
Failure
Prajwal-Microsoft
had a problem deploying
to
production
July 20, 2026 06:02 — with
GitHub Actions
Failure
Prajwal-Microsoft
had a problem deploying
to
production
July 20, 2026 17:38 — with
GitHub Actions
Failure
This branch had an error being deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
This pull request upgrades the default GPT model used throughout the project from
gpt-4.1-minitogpt-5.4-miniand makes related updates to configuration, documentation, and infrastructure. It also improves deployment instructions and scripts to clarify the process for building and deploying container images, and enhances the infrastructure to provision a container registry with private networking support.Model Upgrade and Configuration Updates:
Changed all references, configuration parameters, and documentation from
gpt-4.1-minitogpt-5.4-mini, including default model names, versions, and deployment quotas in files such asinfra/main.bicep,README.md, and various documentation files. [1] [2] [3] [4] [5] [6] [7] [8] [9] [10] [11]Updated allowed Azure deployment regions and model quotas to match the availability of
gpt-5.4-mini.Deployment and Infrastructure Improvements:
Added and documented the process for building and pushing backend/frontend container images to Azure Container Registry (ACR) as a required post-deployment step, updating deployment guides and post-deployment scripts (
azure.yaml,documents/DeploymentGuide.md). [1] [2] [3] [4]Provisioned a dedicated Azure Container Registry in the infrastructure (
infra/main.bicep), including configuration for private networking, DNS zones, and role assignments for web apps to pull images securely. [1] [2] [3]Documentation and Usability:
Updated documentation to reflect new deployment steps, model defaults, and quota recommendations, ensuring consistency and clarity for users setting up or customizing the solution. [1] [2] [3] [4]
Cleaned up unused or testing-specific parameters in the infrastructure template for clarity.
These changes ensure the project uses the latest GPT model, streamline the deployment process, and improve security and maintainability of the infrastructure.
Does this introduce a breaking change?
How to Test
What to Check
Verify that the following are valid
Other Information