Skip to content

chore: main to dev downmerge - #225

Merged
Prajwal-Microsoft merged 16 commits into
devfrom
main
May 20, 2026
Merged

Prajwal-Microsoft merged 16 commits into
devfrom
main

Conversation

@AjitPadhi-Microsoft

Copy link
Copy Markdown
Contributor

Down-merge latest changes from main into dev as part of dependabot maintenance prep (ADO #43844).

Includes:

  • Workflow fixes (restrict deploy workflow to manual trigger)
  • AVM post-deployment guide updates (Bicep CLI prereq)
  • Misc doc formatting fixes

Roopan-Microsoft and others added 16 commits May 4, 2026 12:40
Adds Bicep CLI (v0.33.0+) to the local deployment prerequisites so users provisioning this accelerator locally have the required Bicep version installed before running 'azd up' / 'az deployment'.

Work item: AB#42634
…continue sequence after Bicep CLI prerequisite"
docs: Add Bicep CLI (v0.33.0+) to local deployment prerequisites
fix: Resolved the issue in the QuotaCheck.md file
Remove push and pull_request triggers to prevent automatic resource
provisioning. The workflow now only runs via workflow_dispatch.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
fix: Restrict deploy workflow to manual trigger only

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Down-merges main into dev ahead of Dependabot maintenance, updating deployment workflow triggers and refreshing documentation/scripts to match current infra defaults and prerequisites.

Changes:

  • Update quota-check defaults (models/capacities) and fix the script download URL in docs.
  • Add Bicep CLI (0.33.0+) as a prerequisite across deployment/local dev guides.
  • Restrict the azure-dev deployment workflow to manual (workflow_dispatch) triggers only.

Reviewed changes

Copilot reviewed 6 out of 6 changed files in this pull request and generated no comments.

Show a summary per file
File Description
infra/scripts/quota_check_params.sh Updates default model/capacity list to align with infra/main.bicep deployment capacities.
documents/QuotaCheck.md Updates documented default model/capacity list and corrects the raw GitHub URL for the quota script.
documents/LocalDevelopmentSetup.md Adds Bicep CLI (0.33.0+) to local dev prerequisites.
documents/DeploymentGuide.md Adds Bicep CLI (0.33.0+) to deployment prerequisites.
documents/AVMPostDeploymentGuide.md Adds Bicep CLI prerequisite for AVM post-deployment steps.
.github/workflows/azure-dev.yml Removes push-based triggers so deploy runs only via manual dispatch.
Comments suppressed due to low confidence (2)

documents/QuotaCheck.md:17

  • The “Default Regions” list includes spaces after commas (e.g., eastus, uksouth, ...). quota_check_params.sh splits regions using IFS=',' without trimming, so copy-pasting this list will yield region values with leading spaces and can cause az cognitiveservices usage list --location to fail. Please remove the spaces (or alternatively update the script to trim whitespace) and keep the documented defaults aligned with the script’s DEFAULT_REGIONS.
gpt-4o-mini:50,text-embedding-3-small:10,gpt-realtime-mini:1

📌 Default Regions:

eastus, uksouth, eastus2, northcentralus, swedencentral, westus, westus2, southcentralus, canadacentral

documents/AVMPostDeploymentGuide.md:36

  • After adding Bicep CLI as item 5 under “Required Software”, the numbering under “Azure Requirements” is now off (it restarts at 5 and 6). Please renumber the Azure Requirements list items so the sequence is consistent (e.g., 6, 7, …).
5. **[Bicep CLI](https://learn.microsoft.com/azure/azure-resource-manager/bicep/install)** <small>(v0.33.0+)</small> - Required for compiling infrastructure templates

### Azure Requirements

5. **Azure Access** - One of the following roles on the subscription or resource group:

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@github-actions

Copy link
Copy Markdown

🎉 This PR is included in version 1.3.2 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

This branch was previously deployed

1 inactive deployment
production — 86d51e48 Deployed May 27, 2026 by Prajwal-Microsoft via cleanup-deployment #412
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants