Promote the DockerCompose, Dockerfile, and Helm detectors to default on.#1818
Open
jpinz wants to merge 1 commit into
Open
Promote the DockerCompose, Dockerfile, and Helm detectors to default on.#1818jpinz wants to merge 1 commit into
jpinz wants to merge 1 commit into
Conversation
|
👋 Hi! It looks like you modified some files in the
If none of the above scenarios apply, feel free to ignore this comment 🙂 |
Contributor
There was a problem hiding this comment.
Pull request overview
This pull request promotes the Docker Compose, Dockerfile, and Helm detectors from “experimental” to standard detectors so their detected components are included in scan results by default. This aligns with the orchestrator’s existing behavior where IExperimentalDetector implementations are excluded from results unless explicitly enabled.
Changes:
- Removed
IExperimentalDetectorfromDockerComposeComponentDetector,DockerfileComponentDetector, andHelmComponentDetectorso their outputs are included in scan results by default. - Updated detector documentation pages to remove “experimental” messaging and opt-in
--DetectorArgs ...=Enableinstructions.
Show a summary per file
| File | Description |
|---|---|
| src/Microsoft.ComponentDetection.Detectors/dockercompose/DockerComposeComponentDetector.cs | Stops treating Docker Compose detection as experimental by removing IExperimentalDetector. |
| src/Microsoft.ComponentDetection.Detectors/dockerfile/DockerfileComponentDetector.cs | Stops treating Dockerfile image reference detection as experimental by removing IExperimentalDetector. |
| src/Microsoft.ComponentDetection.Detectors/helm/HelmComponentDetector.cs | Stops treating Helm values image reference detection as experimental by removing IExperimentalDetector. |
| docs/detectors/dockercompose.md | Removes experimental/opt-in wording now that results are included by default. |
| docs/detectors/dockerfile.md | Removes experimental/opt-in wording now that results are included by default. |
| docs/detectors/helm.md | Removes experimental/opt-in wording now that results are included by default. |
Copilot's findings
- Files reviewed: 6/6 changed files
- Comments generated: 0
Member
Author
|
This PR is on hold until #1819 is merged and deployed. With validation that the timeouts for the helm detector has gone down. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request removes the "experimental" status from three component detectors: Docker Compose, Dockerfile, and Helm. The detectors are now considered stable, and their outputs are included in scan results by default, without requiring special command-line arguments. Documentation has been updated to reflect this change, and the
IExperimentalDetectorinterface has been removed from the relevant classes.Detector status changes:
IExperimentalDetectorinterface fromDockerComposeComponentDetector,DockerfileComponentDetector, andHelmComponentDetector, making them standard detectors. [1] [2] [3]Documentation updates:
docs/detectors/dockercompose.mdto remove references to experimental status and the need for--DetectorArgs DockerCompose=Enable. [1] [2]docs/detectors/dockerfile.mdto remove references to experimental status and the need for--DetectorArgs DockerReference=Enable. [1] [2]docs/detectors/helm.mdto remove references to experimental status and the need for--DetectorArgs Helm=Enable. [1] [2]These changes mean that users will now see Docker Compose, Dockerfile, and Helm detection results in their scans by default, improving usability and reducing configuration complexity.