fix(pipewire): disable opus codec support#17227
Draft
binujp wants to merge 1 commit into
Draft
Conversation
binujp
requested review from
christopherco,
ddstreetmicrosoft and
reubeno
as code owners
Contributor
There was a problem hiding this comment.
Pull request overview
Note
Copilot was unable to run its full agentic suite in this review.
Disables Opus codec support in PipeWire builds to comply with Microsoft codec guidance and avoid build failures when opus-devel isn’t available.
Changes:
- Adds Meson flags to disable
opusandbluez5-codec-opusduring%mesonconfiguration in the spec. - Adds a
spec-search-replaceoverlay intended to inject the same Meson disable flags. - Updates the
pipewire.lockinput fingerprint.
Reviewed changes
Copilot reviewed 2 out of 3 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| specs/p/pipewire/pipewire.spec | Adds Meson args to disable Opus/BlueZ Opus codec support at build time. |
| base/comps/pipewire/pipewire.comp.toml | Adds an overlay to inject the same Meson flags via spec search/replace. |
| locks/pipewire.lock | Updates the input fingerprint to reflect the changed inputs. |
binujp
force-pushed
the
bphilip/opus-pipewire-elide
branch
from
0a2bca8 to
204581c
Compare
Disable opus and bluez5-codec-opus in pipewire's meson build config. Opus requires CELA review per Microsoft codec guidance. Pipewire's meson.build requires opus as a dependency (default: auto). Without this overlay, the build fails when opus-devel is unavailable. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
binujp
force-pushed
the
bphilip/opus-pipewire-elide
branch
from
204581c to
06c5187
Compare
📄❌ Rendered specs are out of dateFIX: — run this and commit the result: azldev component render -a --clean-staleOr download the fix patch and apply it: gh run download 25880454780 -R microsoft/azurelinux -n rendered-specs-patch
git apply rendered-specs.patch
Files to addThese files are produced by
Files to removeThese files are in your branch but are not produced by render. Remove them.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Disable opus and bluez5-codec-opus in pipewire's meson build config. Opus requires CELA review per Microsoft codec guidance.
Changes
-D opus=disabled -D bluez5-codec-opus=disabledinto the meson configurationTesting
rpm -qpRshows no opus)pipewire --versionworks correctlyPart of the opus codec removal effort.