star: remove component and drop cpio's now-unused BuildRequires: rmt#17205
Open
PawelWMS wants to merge 1 commit into
Open
star: remove component and drop cpio's now-unused BuildRequires: rmt#17205PawelWMS wants to merge 1 commit into
BuildRequires: rmt#17205PawelWMS wants to merge 1 commit into
Conversation
7d8b6a9 to
dd36e32
Compare
Removes the `star` SRPM (Joerg Schilling's archiver -- distinct from GNU `tar`) from Azure Linux. The `star` SRPM is failing automated package-signing-pipeline decompression and cannot be published; the sub-packages it produced (`star`, `rmt`, `scpio`, `spax`) are not required to ship Azure Linux. The only build-graph edge that kept `star` in the distro was a spurious `BuildRequires: rmt` line in `cpio.spec` -- `rmt` is the remote-magnetic-tape protocol daemon, only consulted by cpio at runtime via the `/etc/rmt` path, never at build time. The two changes must land atomically: dropping the BR first leaves `star` orphaned but still built; dropping `star` first would FTBFS cpio. Changes in this commit ---------------------- 1. `base/comps/cpio/cpio.comp.toml` -- new dedicated component file with two `spec-search-replace` overlays that mirror upstream Fedora rawhide commit https://src.fedoraproject.org/rpms/cpio/c/84d5a4fe965609681000fd3911b7246c2a6973fb\?branch\=rawhide: a. Strip the trailing `, rmt` from `cpio.spec`'s comma- separated `BuildRequires` line (line 51 in the upstream spec). The rendered effect: - BuildRequires: texinfo, autoconf, automake, gettext, gettext-devel, rmt + BuildRequires: texinfo, autoconf, automake, gettext, gettext-devel A plain `spec-remove-tag` would have dropped the entire tag; the scoped regex preserves the rest. b. Drop the `rm -f $RPM_BUILD_ROOT%{_libexecdir}/rmt` line from `%install`. cpio no longer builds its own `rmt` helper under `_libexecdir` (the `--with-rmt=%{_sysconfdir}/rmt` configure flag makes cpio call out to `/etc/rmt` at runtime), so the deletion is a stale leftover -- same upstream Fedora rawhide cleanup. The inline `[components.cpio]` declaration in `base/comps/components.toml` is replaced with a comment pointer to the new file. 2. `base/comps/components.toml` -- delete `[components.star]`. 3. `base/comps/components-publish-channels.toml` -- delete `"star"` from the published-component manifest. 4. `specs/s/star/` -- delete the entire spec directory (`star.spec`, seven Fedora patches, `sources`). No longer rendered. 5. `locks/star.lock` -- delete the now-stale lock file. Validation ---------- - cpio render verified locally: both overlays apply; the BR line is rewritten and the `rm -f $RPM_BUILD_ROOT%{_libexecdir}/rmt` line is gone (`make_install` followed by `rm -f $RPM_BUILD_ROOT%{_infodir}/dir`). - cpio lock refreshed (`locks/cpio.lock`). - cpio has no runtime `Requires: rmt` and no `Recommends: rmt`, so no consumer of the cpio RPM is affected. - Tape-archive utility coverage in AZL: GNU `tar` and `bsdtar` remain. The legacy Schily `star` / `spax` / `scpio` front-ends are not used by any in-distro component. Functionality lost ------------------ - The `star`, `spax`, `scpio`, `rmt` packages are no longer published. `rmt` was niche (remote-magnetic-tape over rsh/ssh); in 2026 the canonical replacements are `tar --rmt-command=ssh` + OpenSSH on the remote end, or modern `dump` (not currently in the distro). If a downstream image needs `rmt` we can import `dump` later.
dd36e32 to
0c39faf
Compare
Contributor
There was a problem hiding this comment.
Pull request overview
Removes the legacy star component (and its rendered spec/patch artifacts) from Azure Linux and updates cpio to no longer build-require rmt, eliminating the last build-graph dependency keeping star in the distro.
Changes:
- Drop the
starcomponent from manifests, publish channels, locks, and rendered specs. - Introduce a dedicated
cpiocomponent definition with overlays to removeBuildRequires: ... rmtand a stale%installcleanup line. - Re-render
cpio.specand refreshlocks/cpio.lockto reflect the new component inputs.
Reviewed changes
Copilot reviewed 13 out of 15 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| specs/s/star/star.spec | Removes rendered spec for star (component deletion). |
| specs/s/star/star-configure-c99.patch | Removes rendered patch artifact for star. |
| specs/s/star/star-1.6-star-mk.patch | Removes rendered patch artifact for star. |
| specs/s/star/star-1.6-manpagereferences.patch | Removes rendered patch artifact for star. |
| specs/s/star/star-1.6-Change-the-sbin-install-dir-to-bin-due-to-Fedora-Cha.patch | Removes rendered patch artifact for star. |
| specs/s/star/star-1.5.2-use-ssh-by-default.patch | Removes rendered patch artifact for star. |
| specs/s/star/star-1.5.2-rmt-rh-access.patch | Removes rendered patch artifact for star. |
| specs/s/star/star-1.5.2-bufferoverflow.patch | Removes rendered patch artifact for star. |
| specs/s/star/sources | Removes rendered sources manifest for star. |
| specs/c/cpio/cpio.spec | Rendered spec update reflecting removal of rmt BR and stale %install line. |
| locks/star.lock | Removes star lockfile as component is deleted. |
| locks/cpio.lock | Updates cpio lock fingerprint after introducing component overlays. |
| base/comps/cpio/cpio.comp.toml | Adds cpio component file with overlays to remove rmt BR and stale %install cleanup. |
| base/comps/components.toml | Removes inline star and cpio component entries (cpio moved to dedicated .comp.toml). |
| base/comps/components-publish-channels.toml | Removes star from the publish channel component list. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Koji build
Summary
Removes the legacy
starSRPM (Joerg Schilling's "Schily" archiver — distinct from GNUtarandbsdtar) from Azure Linux. ThestarSRPM is failing automated package-signing-pipeline decompression and cannot be published; the sub-packages it produced (star,rmt,scpio,spax) are not required to ship Azure Linux.The only build-graph edge that kept
starin the distro was a spuriousBuildRequires: rmtline incpio.spec—rmtis the remote-magnetic-tape protocol daemon, only consulted by cpio at runtime via the/etc/rmtpath, never at build time. The two changes must land atomically: dropping the BR first leavesstarorphaned but still built; droppingstarfirst would FTBFS cpio.Changes
base/comps/cpio/cpio.comp.toml(new)Two
spec-search-replaceoverlays that mirror upstream Fedora rawhide commit 84d5a4fe:, rmtfromcpio.spec'sBuildRequiresline:BuildRequires: texinfo, autoconf, automake, gettext, gettext-devel, rmtBuildRequires: texinfo, autoconf, automake, gettext, gettext-develrm -f $RPM_BUILD_ROOT%{_libexecdir}/rmtline from%install— stale leftover; cpio no longer builds its ownrmthelper under_libexecdir.A plain
spec-remove-tagfor the BR would have dropped the entire tag; the scopedspec-search-replaceregex preserves the other entries.Manifest + spec deletions
base/comps/components.toml— delete[components.star].base/comps/components-publish-channels.toml— delete"star".specs/s/star/— deletestar.spec, seven Fedora patches, andsources.locks/star.lock— delete.Validation
azldev -q comp render -p cpio— clean (STATUS: ok); both overlays apply; the rendered spec shows the cleaned-up BR line and the deleted%installline.azldev -q comp update -p cpio—locks/cpio.lockrefreshed.Requires: rmtand noRecommends: rmt, so no consumer of the cpio RPM is affected.Functionality lost
The
star,spax,scpio,rmtpackages are no longer published.rmtwas niche (remote-magnetic-tape over rsh/ssh); in 2026 the canonical replacements aretar --rmt-command=ssh+ OpenSSH on the remote end, or moderndump(not currently in the distro). If a downstream image needsrmtwe can importdumplater. AZL's tape-archive utility coverage continues via GNUtarandbsdtar.