Remove explicit storage connection-string support in favor of workspace-linked storage by v-elegacheva · Pull Request #774 · microsoft/azure-quantum-python

v-elegacheva · 2026-09-29T19:07:54Z

Summary

Removes explicit storage connection-string support because the Azure Quantum backend only supports storage linked to the workspace. Arbitrary storage accounts are no longer supported for Azure Quantum job storage.

Changes

Removed the Workspace(storage=...) constructor parameter, stored state, property, documentation, and explicit-storage container URI path.
Workspace.get_container_uri(...) now always uses workspace-linked storage.
Made parameters after name keyword-only so a legacy fourth positional argument raises TypeError instead of binding to resource_id.
Removed the obsolete standalone helpers:
- azure.quantum.storage.create_container(...)
- azure.quantum.storage.create_container_using_client(...)`
- azure.quantum.storage.get_container_uri(...)`
Workspace.from_connection_string(...) is unaffected. It authenticates to the Azure Quantum workspace and it related to storage configuration.
Direct storage-account access remains available through azure.storage.blob.

Tests

Added coverage rejecting the legacy fourth positional argument and storage= keyword.
Added production-method coverage for linked-storage container SAS retrieval.
python -m pytest tests/test_workspace.py: 22 passed.
python -m pytest tests --ignore=tests/test_qiskit.py --ignore=tests/test_cirq.py: 138 passed.

Emit a DeprecationWarning when storage= is supplied, pointing users to configure workspace-linked storage instead. Removal is planned for azure-quantum 4.0.0. Transitional behavior (explicit-storage container URI generation) is unchanged. Workspace.from_connection_string(...) is unaffected and does not warn.

azure-pipelines · 2026-09-29T19:08:05Z

Azure Pipelines: There may be pipelines that require an authorized user to comment /azp run to run.

Copilot

Copilot review overview

🟡 Changes recommended

The new tests do not independently verify the warning text or caller attribution as claimed.

Review effort: Balanced
Findings: 1

Open (1)

Test uses production constant instead of literal warning text · New

What changed in this PR

Deprecates explicit workspace storage connection strings while retaining transitional behavior.

Changes:

Adds a DeprecationWarning for non-None storage.
Updates workspace storage and connection-string documentation.
Adds deprecation and compatibility tests.

File	Description
`azure-quantum/azure/quantum/workspace.py`	Implements and documents storage deprecation.
`azure-quantum/tests/test_workspace.py`	Tests warnings and retained storage behavior.

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

Compare against a literal string instead of Workspace._STORAGE_DEPRECATION_MESSAGE so the assertion can actually detect a regression in the warning wording (addresses PR microsoft#774 review comment).

v-elegacheva · 2026-09-29T19:28:21Z

/azp run

azure-pipelines · 2026-09-29T19:28:32Z

Azure Pipelines: Successfully started running 1 pipeline(s).

Copilot

Copilot review overview

🔵 Needs a closer look

The stack-level test does not verify the warning’s exact attribution.

Review effort: Balanced
Findings: None

Resolved since last review (1)

Test uses production constant instead of literal warning text

Previously missed (1)

In code that hasn't changed since last review

Assert the exact warning caller frame to verify stacklevel=2

azure-quantum/tests/test_workspace.py:154

This inequality does not actually verify stacklevel=2: with WorkspaceMock, the expected warning frame is WorkspaceMock.__init__ in mock_client.py, and any other non-workspace.py frame would also pass. Assert the exact caller filename (or instantiate Workspace directly and assert this test file) so an incorrect stack level is caught.

Assert both the source file and line of WorkspaceMock.__init__'s super call so the test precisely verifies stacklevel=2 attribution.

v-elegacheva · 2026-09-29T20:23:43Z

/azp run

azure-pipelines · 2026-09-29T20:23:52Z

Azure Pipelines: Successfully started running 1 pipeline(s).

v-elegacheva · 2026-10-05T17:55:40Z

/azp run

azure-pipelines · 2026-10-05T17:55:50Z

Azure Pipelines: Successfully started running 1 pipeline(s).

Copilot

Copilot review overview

🟢 Approval recommended

The deprecation is correctly implemented, documented, and comprehensively tested without changing transitional behavior.

Review effort: Balanced
Findings: None

v-elegacheva · 2026-10-08T18:47:58Z

/azp run

azure-pipelines · 2026-10-08T18:48:08Z

Azure Pipelines: Successfully started running 1 pipeline(s).

Copilot

🟢 Approval recommended

The implementation consistently removes the legacy path and provides focused regression coverage.

0 open findings

🧠 Review effort: Balanced

…tant

v-elegacheva · 2026-10-08T19:15:52Z

/azp run

azure-pipelines · 2026-10-08T19:16:02Z

Azure Pipelines: Successfully started running 1 pipeline(s).

v-elegacheva · 2026-10-09T20:13:26Z

/azp run

azure-pipelines · 2026-10-09T20:13:36Z

Azure Pipelines: Successfully started running 1 pipeline(s).

Zulfat Nutfullin (rigidit) · 2026-10-13T17:23:30Z

update description that backend already does not support working with storages different from linked to workspace - this is the reason why we are removing that storage param

Zulfat Nutfullin (rigidit) · 2026-10-13T18:39:52Z


-    You can also use a connection string to specify the connection parameters
-    to an Azure Quantum Workspace by calling
+    You can also use an Azure Quantum workspace authentication connection


that's ok to leave this doc as is

Zulfat Nutfullin (rigidit) · 2026-10-13T18:43:52Z

-    If the Azure Quantum workspace does not have linked storage, the caller
-    must also pass a valid Azure storage account connection string.
+    Azure Quantum workspaces require linked storage. Configure linked storage
+    on the workspace instead of passing a storage account connection string.


can you rephrase this to something like "Azure Quantum workspace supports work only with its linked storage."

Zulfat Nutfullin (rigidit) · 2026-10-13T18:44:55Z

        """
-        Creates a new Azure Quantum Workspace client from a connection string.
+        Creates a new Azure Quantum Workspace client from an Azure Quantum
+        workspace authentication connection string.


revert back please

Zulfat Nutfullin (rigidit) · 2026-10-13T18:45:16Z

        :param connection_string:
-            A valid connection string, usually obtained from the
+            A valid Azure Quantum workspace authentication connection string,
+            distinct from a storage account connection string and usually obtained from the


revert back

Zulfat Nutfullin (rigidit) · 2026-10-13T18:46:19Z

        :return: Container URI.
        :rtype: str
        """
+        # Create container URI and get container client


it does not get container client - can skip this comment entirely

Zulfat Nutfullin (rigidit) · 2026-10-13T18:54:30Z

+        ws,
+        "_get_linked_storage_sas_uri",
+        return_value="https://example.com/?sas-token",
+    ) as get_sas:


maybe mock _client.services.storage instead _get_linked_storage_sas_uri?

v-elegacheva requested a balanced review from Copilot September 29, 2026 19:09

Copilot started reviewing on behalf of v-elegacheva September 29, 2026 19:10 View session

Copilot AI reviewed Sep 29, 2026

View reviewed changes

Comment thread azure-quantum/tests/test_workspace.py Outdated

Use literal expected text for storage deprecation warning test

52b361b

Compare against a literal string instead of Workspace._STORAGE_DEPRECATION_MESSAGE so the assertion can actually detect a regression in the warning wording (addresses PR microsoft#774 review comment).

v-elegacheva requested a balanced review from Copilot September 29, 2026 19:44

Copilot started reviewing on behalf of v-elegacheva September 29, 2026 19:45 View session

Copilot AI reviewed Sep 29, 2026

View reviewed changes

Verify exact caller for storage deprecation warning

c9b71bd

Assert both the source file and line of WorkspaceMock.__init__'s super call so the test precisely verifies stacklevel=2 attribution.

Merge branch 'main' into task/55267-deprecate-workspace-storage

3bdc130

v-elegacheva requested a balanced review from Copilot October 6, 2026 18:52

Copilot started reviewing on behalf of v-elegacheva October 6, 2026 18:53 View session

Copilot AI reviewed Oct 6, 2026

View reviewed changes

Zulfat Nutfullin (rigidit) reviewed Oct 6, 2026

View reviewed changes

Comment thread azure-quantum/tests/test_workspace.py Outdated

Remove Workspace explicit storage support

bd68062

v-elegacheva changed the title ~~Deprecate Workspace(storage=...) in favor of workspace-linked storage~~ Remove Workspace(storage=...) in favor of workspace-linked storage Oct 8, 2026

v-elegacheva requested a balanced review from Copilot October 8, 2026 18:58

Copilot started reviewing on behalf of v-elegacheva October 8, 2026 18:59 View session

Copilot AI reviewed Oct 8, 2026

View reviewed changes

Address review nits: spacing, clarifying comment, unused STORAGE cons…

1c86eef

…tant

Remove obselete connection string helpers

7f858f4

v-elegacheva changed the title ~~Remove Workspace(storage=...) in favor of workspace-linked storage~~ Remove explicit storage connection-string support in favor of workspace-linked storage Oct 9, 2026

Zulfat Nutfullin (rigidit) approved these changes Oct 13, 2026

View reviewed changes

Zulfat Nutfullin (rigidit) reviewed Oct 13, 2026

View reviewed changes

Conversation

v-elegacheva commented Sep 29, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Changes

Tests

Uh oh!

azure-pipelines Bot commented Sep 29, 2026

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Copilot review overview

🟡 Changes recommended

Uh oh!

Uh oh!

v-elegacheva commented Sep 29, 2026

Uh oh!

azure-pipelines Bot commented Sep 29, 2026

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Copilot review overview

🔵 Needs a closer look

Uh oh!

v-elegacheva commented Sep 29, 2026

Uh oh!

azure-pipelines Bot commented Sep 29, 2026

Uh oh!

v-elegacheva commented Oct 5, 2026

Uh oh!

azure-pipelines Bot commented Oct 5, 2026

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Copilot review overview

🟢 Approval recommended

Uh oh!

Uh oh!

v-elegacheva commented Oct 8, 2026

Uh oh!

azure-pipelines Bot commented Oct 8, 2026

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

🟢 Approval recommended

Uh oh!

v-elegacheva commented Oct 8, 2026

Uh oh!

azure-pipelines Bot commented Oct 8, 2026

Uh oh!

v-elegacheva commented Oct 9, 2026

Uh oh!

azure-pipelines Bot commented Oct 9, 2026

Uh oh!

Zulfat Nutfullin (rigidit) commented Oct 13, 2026

Uh oh!

Zulfat Nutfullin (rigidit) Oct 13, 2026

Choose a reason for hiding this comment

Uh oh!

Zulfat Nutfullin (rigidit) Oct 13, 2026

Choose a reason for hiding this comment

Uh oh!

Zulfat Nutfullin (rigidit) Oct 13, 2026

Choose a reason for hiding this comment

Uh oh!

Zulfat Nutfullin (rigidit) Oct 13, 2026

Choose a reason for hiding this comment

Uh oh!

Zulfat Nutfullin (rigidit) Oct 13, 2026

Choose a reason for hiding this comment

Uh oh!

Zulfat Nutfullin (rigidit) Oct 13, 2026

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

v-elegacheva commented Sep 29, 2026 •

edited

Loading