Repository navigation
Reuse shared scoped dispatch and ordinary inference in live sessions - #19
Brian Krabach (bkrabach) wants to merge 4 commits into
Conversation
|
The accepted-Streaming follow-up is complete at Normal CI is green: 125 passed, 5 skipped on each Ubuntu/macOS Python 3.11/3.13 job, 50 passed for native-provider adapters, and all package/import checks passed. These jobs use current public Core/Streaming/Context main. Separately, the owned DTU passed 24 focused dispatch/caller/cancellation tests and wheel install/import checks with declared Core The PR is now ready for normal independent review. Work #13 still follows this PR's actual merge. No Live merge or approval bypass has been performed. |
|
Independent source/CI review of exact head The implementation reuses Streaming's scoped dispatcher rather than maintaining a parallel executor. Live retains its activation-validity check; the inherited run/call scopes preserve the active parent identity, ordinary hooks/approval path, shared execution locks, finite execution and lease expiry. Explicit disablement, caller/target restrictions and cancellation remain authoritative. I verified Streaming #68 is merged at CI 39744929291 is successful at this exact head. Logs confirm accepted Streaming, public Core This is independent source and retained-CI verification, not a new reviewer runtime, live-provider or desktop acceptance run. I did not repeat the prior focused tests because their product inputs are unchanged. This comment is not an approving review or a bypass of the repository's normal independent maintainer approval. |
Brian Krabach (bkrabach)
left a comment
There was a problem hiding this comment.
Scoped source review completed at d381577: no actionable findings.
Verified that the successor changes exactly one uv.lock entry relative to 646707c, resolving Streaming e04bba7e85bff9836bfc48cd8ac1db676f4f5fab. Its accepted tree 38ffba2bc03814e53ee0c223a00b7941a5d2161e matches the tested Streaming candidate 20792f1cc7afe0945a789db61a3fa476306efd69. Live application source is unchanged by this successor.
I also checked the Live integration against the accepted dispatcher: the existing finite/live execution scope is reused, ordinary tools enter the shared pipeline once, Live activation remains checked before admitted effects, caller/parent/session authority remains enforced, and nested cancellation retains unknown-outcome reporting without replay. The new caller tests retain denial, revocation, parent attribution and recursion exclusions. The model capability selects through Live's provider owner, retaining its provider pin.
Independently read the completed CI results and logs for run 39744929291: all four Ubuntu/macOS Python 3.11/3.13 jobs passed (125 passed, 5 skipped each), native-adapter passed 50 tests, and all wheel build/isolated import checks passed. The logs resolve accepted Streaming e04bba7 and current Core 9614052f7c9e493977dcba3f5c98ebd4d8591ec5 (2.0.2). CLA is green. The author's separate 24-check and wheel evidence against locked Core 1.6.1 remains separately attributed; I did not rerun those tests.
Source review is clear. This comment is not an eligible approving review: the current GitHub identity is the PR author. The existing maintainer request and normal approval requirement remain in force. No admin merge or protection change is authorized for Live. Accepted-main Work qualification still follows actual Live/Work acceptance; this review does not relabel the frozen candidate evidence.
Reuse Streaming's scoped dispatcher and attributed ordinary-inference capability from loop-live, removing its duplicate implementation. Portable controllers bind during a live parent call while retaining normal tool hooks, approvals, call identity, cancellation, and finite-turn compatibility. Existing host disablement and caller/tool restrictions remain authoritative. No decision-provider, browser, application or CLI dependency is added.
Streaming #68 is now merged. The lock resolves its accepted public-main commit
e04bba7e85bff9836bfc48cd8ac1db676f4f5fab; the maintained dependency still tracks canonical Streaming main. Successord38157796843c7aea65d5afa74084429d5f3f23fchanges only this lock entry. Work #13 follows this PR's actual merge.Validation against accepted Streaming main in a fresh owned DTU environment: 24 dispatch/caller/cancellation tests passed, locked dependency installation passed, and the built wheel passed a separate isolated installation/import check without application adapters. Local tests used declared Core
1.6.1and Context Simple5055ddc98c46df575c16d6f8bb751c7a1306b69d; these are offline authority/compatibility checks, not live-model or desktop acceptance. The attempted current-Core source build in this arm64 DTU lacked a C linker, so it does not count as current-Core acceptance. No system tooling or preview runtime was changed.Normal CI now passes against current public Core/Streaming/Context main: 125 passed, 5 skipped on each Ubuntu/macOS Python 3.11/3.13 job, 50 passed in the native-provider adapter job, and all wheel build/import checks passed. This supplies the current-Core acceptance that the local environment could not build. Ready for independent review; normal repository approval rules apply.