Repository navigation
Forward native request timeouts through the CLI adapter - #10
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Current provider-owned native transport passes keyword options, including
timeout, through_native_response. The host adapter dropped those options and raised TypeError before a native send. Forward the options unchanged while preserving the existing attribution scope and its cleanup.Regression cases cover omitted timeout, a scalar deadline and None through success, failure and cancellation, checking exact input identity, one dispatch and restored attribution. The current provider remains responsible for deadline semantics; this adds no replay or cancellation behavior.
Validation: 34 native/image adapter tests pass against provider-openai a4a6ad9f, OpenAI SDK 3.19.2, and websockets 16.1.1; no provider calls. This is a separate compatibility fix from manager-error PR #9. Fresh CI also exposed provider-openai's missing runtime httpx dependency, addressed separately in microsoft/amplifier-module-provider-openai#115. The Microsoft and Unified inherited wrappers were checked; the distinct bkrabach adapter owns its older transport and does not inherit this method.