Repository navigation
Support unbounded Goal traversal and truthful child completion - #120
Draft
Ken Chau (kenotron-ms) wants to merge 1 commit into
Draft
Ken Chau (kenotron-ms) wants to merge 1 commit into
Ken Chau (kenotron-ms) wants to merge 1 commit into
Conversation
Ken Chau (kenotron-ms)
requested a review
from Brian Krabach (bkrabach)
as a code owner
October 9, 2026 18:02
Ken Chau (kenotron-ms)
marked this pull request as draft
October 9, 2026 18:03
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Allow explicit graph
max_steps=0to disable main/subgraph traversal and gate/failure-routing retry ceilings, and prevent interrupted spawned children from being promoted to success by intermediate output or status files. Other graph defaults and node infrastructure retry policies remain unchanged.Why this change is needed
An author-selected convergence loop can hit an engine-imposed ceiling before satisfying its goal. Separately, nonempty child text or fresh success files do not establish that an incomplete/cancelled execution finished. These are distinct changes: traversal policy and truthful lifecycle interpretation.
How it works
PipelineEngine stores the graph limit, rejects negative/invalid values, and treats zero as unlimited in both execution loops and gate/failure retry checks. AmplifierBackend returns non-explicit FAIL with
execution_complete=Falsefor incomplete/cancelled spawn envelopes. Codergen skips status-file overrides for those results; completed children retain the existing verdict channel. Cancellation and externally owned deadlines remain in force.Importance and ecosystem impact
specs/EXTENSIONS.md§49 records the author-controlled graph extension against Attractor canonical sections 3.2/4.5 and coding-agent 2.5, retaining surrounding lifecycle/verification obligations and existing history-entry turn counting. This is shared runner behavior consumed by resolvers, not a Resolve placement or permission change. Downstream publication must follow upstream review and exact runtime qualification. The owner later selected Goal-budget removal without changing loop-pipeline; this draft is excluded from that release and must not be silently pinned into it.Verification checklist
Verification evidence
Historical body reports 14 new focused controls and an earlier expanded 62. Candidate full suite reported 2,379 passed/9 failures against a 2,344-passed baseline with the same nine mtime-freshness failures; final local-suite accounting remained unresolved. A later retained transcript excerpt records 2383 passed / 9 failed / 237 skipped; its exact relationship to the earlier 2379-pass scope is not established, so the counts are not combined or presented as a new full-suite pass. New tests cover root/subgraph convergence at 160 calls, failure routing beyond 50, and interrupted text/success-file refusal while completed-child files remain authoritative. The hosted uncapped Goal used an older runner with an uncapped Goal copy, so it does not qualify this engine delta. These are recorded results, not a newly executed acceptance run.
Current-head remote evidence:
05b239de4c41586088b3c3ac4dac5c4fa4750fea, conclusionsuccess.Notes for reviewers
Review the graph extension and completion-envelope change independently. Trace the additive Outcome field through status overrides and transcript markers; default True is compatibility-sensitive. Unlimited retries are not permission to omit cancellation, resource containment or terminal verification. Historical successful Goal execution cannot be transferred to different runner bytes.