Repository navigation
Restore accepted native recovery state when checkpoint saving fails - #24
Merged
Merged
Conversation
Generated with Amplifier Co-Authored-By: Amplifier <240397093+microsoft-amplifier@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Restore the previously accepted native-recovery summary and identity if exporting or saving the next piece raises an exception or is cancelled. Previously, the explicit helper installed the new summary before save_progress succeeded, allowing an unaccepted piece to remain installed and appear in a later export.
This is the explicit offline native recovery helper, not ordinary request preparation or a new mandatory durability service. The caller still owns session exclusivity and atomic external writes. In-memory rollback does not undo storage writes made by the callback. No Legacy engine/default/migration work is included.
Verification
Independent isolated DTU, actual installed production bytes matched candidate 52108cb:
No live vendor/model/desktop calls or all-provider runtime qualification. IP/DNS were denied; caught non-model discovery attempts were retained honestly. Local Python 3.11/3.12 were not executed for Managed. Earlier setup/plugin/fixture failures remain in the original receipts; no behavioral assertions were weakened. Repository policy-only CI, if that is the current workflow, is not represented as a hosted test suite.
Integration and review
Foundation PR microsoft/amplifier-foundation#446 merged first as a5f91fc4765dd3c6a1496b400c4fe428e5aa06f2. Its distinct receipt-preservation fix owns upstream transcript repair. This PR fixes the accepted-state transaction boundary of the explicit recovery helper without adding a provider or storage dependency.
Fresh second-opinion reviews used actual openai/gpt-6-astra and fable/claude-fable-5-1 on an identical supplied-code/evidence H0-H8 brief. Both supported Managed publication after Foundation merge. Those were bounded reviews, not full-diff audits or GitHub approvals. Independent source review and actual DTU validation also completed.
Legacy retirement/migration #3 remains deferred and unfulfilled. No merge, host install, release or teardown of the historical Boundary environment is included in this PR.