Repository navigation
fix(cli): share directory write policy with apply-patch - #377
Merged
Brian Krabach (bkrabach) merged 2 commits intoOct 21, 2026
Merged
Conversation
Generated with Amplifier Co-Authored-By: Amplifier <240397093+microsoft-amplifier@users.noreply.github.com>
Generated with Amplifier Co-Authored-By: Amplifier <240397093+microsoft-amplifier@users.noreply.github.com>
Brian Krabach (bkrabach)
marked this pull request as ready for review
October 21, 2026 12:11
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Share operator directory write grants and denies with already-declared
tool-apply-patchmodules during CLI configuration assembly. The filesystem operator settings are stored undertool-filesystem; exact-module override matching did not previously project them to the separate patch module.This is an additive configuration projection. It does not activate an absent patch module, copy filesystem defaults/read policy/source/engine, or update tools that are already mounted.
Changes
additional_allowed_write_pathsfield. Preserve an omitted patch allowlist and explicit[]so the patch module can select its default only at mount, aftersession.working_diris available. Union shared denies with patch denies.denied_write_paths: nullas “no additional denies”; do not forward null or clear patch-specific denies. A null allowed-path field remains invalid.Verification
The corrected source revision was qualified with:
Filesystem module support for
additional_allowed_write_pathsmerged upstream in PR #10 at515599f0d0763a946aa96ed1d0110db723f5c386; the three source pins used for this qualification match that merge.Two fresh brief-only reviews returned conditional approval based on the supplied source excerpts and qualification results. They were not independent file audits or GitHub approvals.
CI and merge gate
The existing six-job pytest matrix (Ubuntu, macOS, and Windows on Python 3.11 and 3.12) and two POSIX PTY jobs must pass on this exact head. This PR remains a draft until current-head CI is verified and Root confirms the gate. Do not merge while checks are pending.
Compatibility and breaking changes
No CLI command or user-settings schema changes. The projection requires a filesystem module version that consumes
additional_allowed_write_paths; older versions do not consume the new field. The upstream support is merged, but this change does not refresh modules already mounted in a running session. No restart or live-refresh remedy is claimed.