Repository navigation
Remove personal Highway paths and defer batch placement to callers - #374
Merged
Merged
Conversation
Generated with Amplifier Co-Authored-By: Amplifier <240397093+microsoft-amplifier@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Remove personal home-directory batch examples from the CLI-shipped ten-lane-highway guidance. Batch placement belongs to the caller's workspace conventions, not a generic skill's hardcoded host layout.
BATCH_DIRestablished before creating state or launching lanes.BATCH_DIRlives; Highway continues to define its internal files and workflow. AnyHIGHWAY_LANES_ROOToverride must remain in the same workspace.Why this repository
The
/goalfamily, including Highway, ships inamplifier-app-cli. The skills bundle does not own these assets. Downstream managers can supply their own workspace-contained layout without introducing a dependency or product-specific directory into the generic Highway skill.The old examples steered callers toward sibling batch directories outside temporary workspaces, leaving run state behind when the workspace was removed. This patch removes that misleading guidance rather than prescribing another personal setup.
Verification
git diff --check: passed.uv build --wheel: passed. Inspected the built wheel and verified byte-for-byte agreement with the corrected skill, first-run example, and teardown script.hw-<batch>tmux socket names are intentionally unchanged.Independent Second Opinion reviews
Astra (
gpt-6-astra) and Fable (claude-fable-5-1) both executed and approved PR publication after reviewing the same frozen final four-file patch and verification brief. Neither found an evidence-backed blocker. The final review followed removal of a residual teardown-help example and clarification of batch location versus internal layout.These were bounded, read-only, evidence-brief reviews—not independent test execution or whole-repository inspection. Nonblocking notes concern fallback guidance for callers without conventions and test coverage breadth. No live runtime defect was established from those notes, and no unrelated fix was added.
Scope and limits
Guidance-only, not runtime containment enforcement. No path-validation, launcher behavior, cwd, dependency, settings, or CI changes. One shell file changes only its usage comment. No host installation, cache migration, or running-session reload occurred.
The new text assertions inherit the existing test module's GNU/Linux/bash skip policy; they do not prove agent compliance or actual filesystem containment. No live autonomous-lane/DTU behavior qualification is claimed for this documentation-only correction. Integration tests were not rerun locally; the default suite retains its existing integration deselection.
Only app-cli needs a PR for this correction. Other workspace/runtime issues identified during investigation remain outside this bounded change. No merge authorization.