Skip to content

Remove personal Highway paths and defer batch placement to callers - #374

Merged
Brian Krabach (bkrabach) merged 1 commit into
mainfrom
fix/highway-workspace-guidance
Oct 16, 2026
Merged

Brian Krabach (bkrabach) merged 1 commit into
mainfrom
fix/highway-workspace-guidance

Conversation

@bkrabach

Copy link
Copy Markdown
Collaborator

Summary

Remove personal home-directory batch examples from the CLI-shipped ten-lane-highway guidance. Batch placement belongs to the caller's workspace conventions, not a generic skill's hardcoded host layout.

  • Main skill and first-run walkthrough require a workspace-contained BATCH_DIR established before creating state or launching lanes.
  • Callers choose where BATCH_DIR lives; Highway continues to define its internal files and workflow. Any HIGHWAY_LANES_ROOT override must remain in the same workspace.
  • Remove the remaining home-path example from the teardown script's usage comment. No executable shell line changes.
  • Add two parametrized regression cases covering both entrypoint documents and the teardown help text.

Why this repository

The /goal family, including Highway, ships in amplifier-app-cli. The skills bundle does not own these assets. Downstream managers can supply their own workspace-contained layout without introducing a dependency or product-specific directory into the generic Highway skill.

The old examples steered callers toward sibling batch directories outside temporary workspaces, leaving run state behind when the workspace was removed. This patch removes that misleading guidance rather than prescribing another personal setup.

Verification

  • Both new document cases failed before the guidance correction.
  • Final Highway suite: 71 passed.
  • Full default suite in the declared Python 3.12 project environment with unchanged locked dependencies: 2742 passed, 1 skipped, 13 integration tests deselected, 1 expected failure.
  • git diff --check: passed.
  • uv build --wheel: passed. Inspected the built wheel and verified byte-for-byte agreement with the corrected skill, first-run example, and teardown script.
  • Scanned every shipped Highway Markdown/shell asset: no personal home-path examples remain. Existing hw-<batch> tmux socket names are intentionally unchanged.

Independent Second Opinion reviews

Astra (gpt-6-astra) and Fable (claude-fable-5-1) both executed and approved PR publication after reviewing the same frozen final four-file patch and verification brief. Neither found an evidence-backed blocker. The final review followed removal of a residual teardown-help example and clarification of batch location versus internal layout.

These were bounded, read-only, evidence-brief reviews—not independent test execution or whole-repository inspection. Nonblocking notes concern fallback guidance for callers without conventions and test coverage breadth. No live runtime defect was established from those notes, and no unrelated fix was added.

Scope and limits

Guidance-only, not runtime containment enforcement. No path-validation, launcher behavior, cwd, dependency, settings, or CI changes. One shell file changes only its usage comment. No host installation, cache migration, or running-session reload occurred.

The new text assertions inherit the existing test module's GNU/Linux/bash skip policy; they do not prove agent compliance or actual filesystem containment. No live autonomous-lane/DTU behavior qualification is claimed for this documentation-only correction. Integration tests were not rerun locally; the default suite retains its existing integration deselection.

Only app-cli needs a PR for this correction. Other workspace/runtime issues identified during investigation remain outside this bounded change. No merge authorization.

Generated with Amplifier

Co-Authored-By: Amplifier <240397093+microsoft-amplifier@users.noreply.github.com>
@bkrabach
Brian Krabach (bkrabach) merged commit 7199e69 into main Oct 16, 2026
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants