Repository navigation
feat: add process-local startup update check opt-out - #371
Merged
Brian Krabach (bkrabach) merged 2 commits intoOct 12, 2026
Merged
Conversation
Skip automatic update settings, network and timestamp activity only when AMPLIFIER_SKIP_STARTUP_UPDATE_CHECK is exactly 1. Preserve default frequency policy and explicit update commands. Verified as an installed wheel in the existing isolated DTU: 79 tests and three guarded startup-entry probes. Generated with Amplifier Co-Authored-By: Amplifier <240397093+microsoft-amplifier@users.noreply.github.com>
Generated with Amplifier Co-Authored-By: Amplifier <240397093+microsoft-amplifier@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
AMPLIFIER_SKIP_STARTUP_UPDATE_CHECK=1as a process-local opt-out for the automatic startup update checker.amplifier update.Motivation
An engineering worker with a read-only configuration home can fail during automatic startup update bookkeeping: timestamp persistence attempts to acquire
~/.amplifier/settings.yaml.lock, raisesEROFS, and the error handler attempts the same save again.This PR provides a narrow opt-out for callers that deliberately suppress automatic update work without changing saved settings or making shared installations writable.
AMPLIFIER_SKIP_STARTUP_UPDATE_CHECK=1 amplifier run "your prompt"Only the exact value
1opts out. Unset, empty,0,true, and whitespace-padded values retain the existing behavior.Verification
The original change was built and installed as a wheel in an isolated test environment on October 11, 2026:
tests/test_startup_checker.pyandtests/test_run_sigint_main_thread_guard.py.tests/test_update_reporting.py._run_startup_update_check, with missing, malformed, and valid settings: no update-settings or network attempts were recorded under the opt-out.The PR is a single clean cherry-pick onto the current upstream base. The implementation, new tests, and README are byte-identical to the previously verified change; the AGENTS addition contains only startup-control guidance. Stable patch identity matches the original change. Unrelated local launcher-repair commits are excluded.
These results are retained verification evidence, not a fresh full-suite run on the PR branch. Repository CI results remain separate.
Scope and limits
amplifier updateremains enabled; the new regression invokes its real Click command with mocked update boundaries.