Repository navigation
.NET: Correct endpoint override instructions in Responses samples - #9639
Merged
Vincent Biret (baywet) merged 1 commit intoOct 23, 2026
Merged
Vincent Biret (baywet) merged 1 commit into
Vincent Biret (baywet) merged 1 commit into
Conversation
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
The documentation and comment changes match the existing server bindings and verified client configuration, with no unresolved issues.
No open issues 🎉
What changed in this PR
Corrects endpoint configuration guidance for the two .NET Responses hosting samples so it matches their existing fixed server bindings.
Changes:
- Replaces inaccurate
ASPNETCORE_URLSoverride instructions with guidance to change the URL passed toapp.Run. - Directs users to set
RESPONSES_SERVER_URLin the client shell to the same address. - Updates documentation and comments only; executable code and default ports remain unchanged.
| File | Description |
|---|---|
dotnet/samples/04-hosting/af-hosting/local_responses/Server/README.md |
Corrects address configuration instructions for the agent server. |
dotnet/samples/04-hosting/af-hosting/local_responses/Server/Program.cs |
Corrects the binding comment beside the port 5000 URL. |
dotnet/samples/04-hosting/af-hosting/local_responses_workflow/Server/README.md |
Corrects address configuration instructions for the workflow server. |
dotnet/samples/04-hosting/af-hosting/local_responses_workflow/Server/Program.cs |
Corrects the binding comment beside the port 5001 URL. |
Review effort: Balanced
Vincent Biret (baywet)
approved these changes
Oct 23, 2026
Vincent Biret (baywet)
left a comment
Member
There was a problem hiding this comment.
Thanks for the contribution!
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation & Context
Both bring-your-own-route Responses server guides say
ASPNETCORE_URLScan override the listening address. Each server instead callsapp.Runwith a fixed URL, so that instruction does not match the sample's address binding.Description & Review Guide
app.Runand setRESPONSES_SERVER_URLin the client shell to the same address.Run(url)replaces the address collection with that URL. No .NET build, sample execution, HTTP request, or cloud call was run.Related Issue
N/A - trivial change. This corrects an inaccurate configuration instruction to describe the existing server and client code; it adds no behavior or API. The open session-storage change #8417 does not change these instructions or the URL binding.
AI Assistance
AI assistance details: Documentation, static verification, and this PR description.
Contribution Checklist