Skip to content

.NET: Correct endpoint override instructions in Responses samples - #9639

Merged
Vincent Biret (baywet) merged 1 commit into
microsoft:mainfrom
ktz03:docs/af-responses-endpoint-guide-20261023
Oct 23, 2026
Merged

Vincent Biret (baywet) merged 1 commit into
microsoft:mainfrom
ktz03:docs/af-responses-endpoint-guide-20261023

Conversation

@ktz03

Copy link
Copy Markdown
Contributor

Motivation & Context

Both bring-your-own-route Responses server guides say ASPNETCORE_URLS can override the listening address. Each server instead calls app.Run with a fixed URL, so that instruction does not match the sample's address binding.

Description & Review Guide

  • What are the major changes? Correct both server guides and the adjacent binding comments: change the URL passed to app.Run and set RESPONSES_SERVER_URL in the client shell to the same address.
  • What is the impact of these changes? Documentation and comments only. The default ports, executable code, and client configuration behavior are unchanged.
  • What do you want reviewers to focus on? Both explicit server URLs and both client environment-variable reads were checked against the same source revision. The ASP.NET Core 10 source confirms that Run(url) replaces the address collection with that URL. No .NET build, sample execution, HTTP request, or cloud call was run.

Related Issue

N/A - trivial change. This corrects an inaccurate configuration instruction to describe the existing server and client code; it adds no behavior or API. The open session-storage change #8417 does not change these instructions or the URL binding.

AI Assistance

  • No material AI assistance was used.
  • This is an AI-assisted contribution. I reviewed, understood, and verified all submitted content and accept responsibility for it.

AI assistance details: Documentation, static verification, and this PR description.

Contribution Checklist

  • The code builds clean without any errors or warnings
  • All unit tests pass, and I have added new tests where possible
  • The PR follows the Contribution Guidelines
  • This PR links to an agreed issue with no competing open PR, or the Related Issue section documents a trivial-change or repository-automation exception.
  • This is not a breaking change.

Copilot AI balanced review requested due to automatic review settings October 23, 2026 09:57
@ktz03
LI (ktz03) deployed to github-app-auth October 23, 2026 09:57 — with GitHub Actions Active
@ktz03
LI (ktz03) deployed to github-app-auth October 23, 2026 09:57 — with GitHub Actions Active
@agent-framework-automation agent-framework-automation Bot added documentation Usage: [Issues, PRs], Target: documentation in the code base and learn docs .NET Usage: [Issues, PRs], Target: .Net labels Oct 23, 2026

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Approval recommended

The documentation and comment changes match the existing server bindings and verified client configuration, with no unresolved issues.

No open issues 🎉

What changed in this PR

Corrects endpoint configuration guidance for the two .NET Responses hosting samples so it matches their existing fixed server bindings.

Changes:

  • Replaces inaccurate ASPNETCORE_URLS override instructions with guidance to change the URL passed to app.Run.
  • Directs users to set RESPONSES_SERVER_URL in the client shell to the same address.
  • Updates documentation and comments only; executable code and default ports remain unchanged.
File Description
dotnet/​samples/​04-hosting/​af-hosting/​local_responses/​Server/​README.md Corrects address configuration instructions for the agent server.
dotnet/​samples/​04-hosting/​af-hosting/​local_responses/​Server/​Program.cs Corrects the binding comment beside the port 5000 URL.
dotnet/​samples/​04-hosting/​af-hosting/​local_responses_workflow/​Server/​README.md Corrects address configuration instructions for the workflow server.
dotnet/​samples/​04-hosting/​af-hosting/​local_responses_workflow/​Server/​Program.cs Corrects the binding comment beside the port 5001 URL.

Review effort: Balanced

@baywet Vincent Biret (baywet) left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution!

@baywet
Vincent Biret (baywet) added this pull request to the merge queue Oct 23, 2026
Merged via the queue into microsoft:main with commit 9581926 Oct 23, 2026
38 checks passed

This branch was successfully deployed

1 active deployment
github-app-auth — 043903bf Deployed Oct 23, 2026 by ktz03 via team_check #7309
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Usage: [Issues, PRs], Target: documentation in the code base and learn docs .NET Usage: [Issues, PRs], Target: .Net

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants