Repository navigation
Python: Fix A2A dependency bounds test environment - #9619
Merged
Eduard van Valkenburg (eavanvalkenburg) merged 2 commits intoOct 23, 2026
Merged
Eduard van Valkenburg (eavanvalkenburg) merged 2 commits into
Eduard van Valkenburg (eavanvalkenburg) merged 2 commits into
Conversation
ZedingZhang (ZedingZhang)
deployed
to
github-app-auth
October 23, 2026 06:26 — with
GitHub Actions
Active
ZedingZhang (ZedingZhang)
deployed
to
github-app-auth
October 23, 2026 06:26 — with
GitHub Actions
Active
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
The dependency declaration, lockfile, and regression test are consistent, with no blocking issues identified.
No open issues 🎉
What changed in this PR
Fixes the A2A isolated dependency-bounds test environment described in #9519 by including the orchestration package needed during test collection, without changing runtime requirements.
Changes:
- Adds
agent-framework-orchestrationsto A2A’s test dependency group. - Updates the lockfile to reflect the test-only dependency.
- Adds a regression test confirming the A2A test plan includes the local orchestration package.
| File | Description |
|---|---|
python/uv.lock |
Records A2A’s orchestration test dependency. |
python/scripts/dependencies/tests/test_dependency_bounds_runtime.py |
Verifies the real A2A plan includes local orchestrations. |
python/packages/a2a/pyproject.toml |
Declares the missing test-only dependency. |
Review effort: Balanced
ZedingZhang (ZedingZhang)
deployed
to
github-app-auth
October 23, 2026 06:29 — with
GitHub Actions
Active
ZedingZhang (ZedingZhang)
deployed
to
github-app-auth
October 23, 2026 06:33 — with
GitHub Actions
Active
ZedingZhang (ZedingZhang)
deployed
to
github-app-auth
October 23, 2026 06:39 — with
GitHub Actions
Active
ZedingZhang (ZedingZhang)
marked this pull request as ready for review
October 23, 2026 06:40
ZedingZhang (ZedingZhang)
requested review from
SergeyMenshykh,
Tao Chen (TaoChenOSU),
Eduard van Valkenburg (eavanvalkenburg),
Giles Odigwe (giles17),
Jose Alvarez (jpalvarezl),
Evan Mattson (moonbox3),
Roger Barreto (rogerbarreto),
sophia-ramsey and
westey (westey-m)
as code owners
October 23, 2026 06:40
ZedingZhang (ZedingZhang)
deployed
to
github-app-auth
October 23, 2026 06:40 — with
GitHub Actions
Active
Eduard van Valkenburg (eavanvalkenburg)
approved these changes
Oct 23, 2026
Eduard van Valkenburg (eavanvalkenburg)
deployed
to
github-app-auth
October 23, 2026 14:09 — with
GitHub Actions
Active
Eduard van Valkenburg (eavanvalkenburg)
enabled auto-merge
October 23, 2026 14:10
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation & Context
The isolated A2A dependency-bounds test environment cannot collect
test_a2a_group_chat.pybecause it importsagent_framework.orchestrations, but A2A does not declare the corresponding test dependency. This prevents the weekly dependency-maintenance workflow from reaching upper-bound validation.Description & Review Guide
agent-framework-orchestrationsto A2A'stestdependency group, following the existing AG-UI configuration, and refreshuv.lock. Add a regression test against the real A2A dependency-bounds plan to ensure the local orchestrations package is included.lowest-directandhighestscenarios now complete their unit-test and Pyright tasks. The dependency is limited to testing; the built wheel's runtime requirements are unchanged.Related Issue
Fixes #9519.
This is a trivial test-environment configuration correction: existing A2A tests already import
agent_framework.orchestrations, but the package does not declare the corresponding test dependency. This change addsthat missing declaration using the existing AG-UI test dependency pattern, updates the lockfile, and adds a regression test. It restores the intended isolated CI test environment without changing public APIs or published runtime requirements.
No competing open PR was found.
AI Assistance
AI assistance details: Codex assisted with issue analysis, reproduction, implementation, the regression test, verification, and this PR description. I have reviewed all submitted content and take resonsibility for it.
Contribution Checklist
breaking changelabel (or add "[BREAKING]" to the title prefix, before or after any language prefix) — a workflow keeps the label and title prefix in sync automatically.The affected A2A test/typing scenarios, all dependency-runtime tests, formatting/lint, lockfile check, package build, and commit hooks pass. A broader dependency-script test run has one existing Windows path-separator assertion failure in
test_release_probe_uses_only_the_required_internal_dependency_closure; the same failure was reproduced from an unmodified base-commit snapshot.The advisory Public API Compatibility job fails in Griffe 2.4.0 with
AliasResolutionErrorforEdgeGroup.builtin_type -> builtins.type. The same error was reproduced by comparing the unmodified base commita8e284ca8ce7c2a6b4a4641ef35e131d75a5cda3against an extracted copy of itself. The remaining fork test workflows are awaiting maintainer approval.