Skip to content

Python: Fix A2A dependency bounds test environment - #9619

Merged
Eduard van Valkenburg (eavanvalkenburg) merged 2 commits into
microsoft:mainfrom
ZedingZhang:fix/9519-a2a-test-dependencies
Oct 23, 2026
Merged

Eduard van Valkenburg (eavanvalkenburg) merged 2 commits into
microsoft:mainfrom
ZedingZhang:fix/9519-a2a-test-dependencies

Conversation

@ZedingZhang

@ZedingZhang ZedingZhang (ZedingZhang) commented Oct 23, 2026 •

Copy link
Copy Markdown
Contributor

Motivation & Context

The isolated A2A dependency-bounds test environment cannot collect test_a2a_group_chat.py because it imports agent_framework.orchestrations, but A2A does not declare the corresponding test dependency. This prevents the weekly dependency-maintenance workflow from reaching upper-bound validation.

Description & Review Guide

  • What are the major changes? Add agent-framework-orchestrations to A2A's test dependency group, following the existing AG-UI configuration, and refresh uv.lock. Add a regression test against the real A2A dependency-bounds plan to ensure the local orchestrations package is included.
  • What is the impact of these changes? A2A's isolated lowest-direct and highest scenarios now complete their unit-test and Pyright tasks. The dependency is limited to testing; the built wheel's runtime requirements are unchanged.
  • What do you want reviewers to focus on? The test-only dependency declaration and the regression test's coverage of the generated isolated environment.

Related Issue

Fixes #9519.

This is a trivial test-environment configuration correction: existing A2A tests already import agent_framework.orchestrations, but the package does not declare the corresponding test dependency. This change adds
that missing declaration using the existing AG-UI test dependency pattern, updates the lockfile, and adds a regression test. It restores the intended isolated CI test environment without changing public APIs or published runtime requirements.

No competing open PR was found.

AI Assistance

  • No material AI assistance was used.
  • This is an AI-assisted contribution.

AI assistance details: Codex assisted with issue analysis, reproduction, implementation, the regression test, verification, and this PR description. I have reviewed all submitted content and take resonsibility for it.

Contribution Checklist

  • The code builds clean without any errors or warnings
  • All unit tests pass, and I have added new tests where possible
  • The PR follows the Contribution Guidelines
  • This PR links to an agreed issue with no competing open PR, or the Related Issue section documents a trivial-change or repository-automation exception.
  • This is not a breaking change. If it is a breaking change, add the breaking change label (or add "[BREAKING]" to the title prefix, before or after any language prefix) — a workflow keeps the label and title prefix in sync automatically.

The affected A2A test/typing scenarios, all dependency-runtime tests, formatting/lint, lockfile check, package build, and commit hooks pass. A broader dependency-script test run has one existing Windows path-separator assertion failure in test_release_probe_uses_only_the_required_internal_dependency_closure; the same failure was reproduced from an unmodified base-commit snapshot.

The advisory Public API Compatibility job fails in Griffe 2.4.0 with AliasResolutionError for EdgeGroup.builtin_type -> builtins.type. The same error was reproduced by comparing the unmodified base commit a8e284ca8ce7c2a6b4a4641ef35e131d75a5cda3 against an extracted copy of itself. The remaining fork test workflows are awaiting maintainer approval.

Copilot AI balanced review requested due to automatic review settings October 23, 2026 06:26
@agent-framework-automation agent-framework-automation Bot added the python Usage: [Issues, PRs], Target: Python label Oct 23, 2026

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Approval recommended

The dependency declaration, lockfile, and regression test are consistent, with no blocking issues identified.

No open issues 🎉

What changed in this PR

Fixes the A2A isolated dependency-bounds test environment described in #9519 by including the orchestration package needed during test collection, without changing runtime requirements.

Changes:

  • Adds agent-framework-orchestrations to A2A’s test dependency group.
  • Updates the lockfile to reflect the test-only dependency.
  • Adds a regression test confirming the A2A test plan includes the local orchestration package.
File Description
python/​uv.lock Records A2A’s orchestration test dependency.
python/​scripts/​dependencies/​tests/​test_dependency_bounds_runtime.py Verifies the real A2A plan includes local orchestrations.
python/​packages/​a2a/​pyproject.toml Declares the missing test-only dependency.

Review effort: Balanced

Merged via the queue into microsoft:main with commit edc2427 Oct 23, 2026
54 checks passed
@ZedingZhang
ZedingZhang (ZedingZhang) deleted the fix/9519-a2a-test-dependencies branch October 23, 2026 15:02

This branch was successfully deployed

1 active deployment
github-app-auth — 90903abf Deployed Oct 23, 2026 by eavanvalkenburg via add_label #26043
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

python Usage: [Issues, PRs], Target: Python

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Dependency bounds test failed

3 participants