Repository navigation
Conversation
Contributor
There was a problem hiding this comment.
🟡 Changes recommended
Replacing a supported label tracker loses the client binding and restores cross-configuration routing.
1 open finding
What changed in this PR
Addresses #7455 C2 by routing quarantine calls through the owning security configuration.
Changes:
- Binds quarantine clients, including
None, to label-tracking middleware. - Preserves the global fallback for standalone calls.
- Adds regression coverage and updates ownership documentation.
| File | Description |
|---|---|
| python/packages/core/tests/test_security.py | Tests client isolation, missing clients, and standalone fallback. |
| python/packages/core/agent_framework/security.py | Adds middleware-bound client selection and updates documentation. |
🧠 Review effort: Balanced
💡 Add a code-review agent skill for context-aware, tailored reviews. Learn more in the docs.
Preserve latest upstream changes and keep quarantine ownership regression coverage.
Author
|
Updated the branch against the latest main. No merge conflicts, and the diff is still limited to the original two files. The CI workflows are showing "action_required". Could a maintainer approve the runs so we can get the PR validated? Thanks! |
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Motivation
Addresses the documented quarantine-client ownership limitation in #7455 (C2).
SecureAgentConfigaccepts a per-agent quarantine client, butquarantined_llmselects a process-global client. Multiple agents running in one process can therefore route quarantine content through another agent's configured client.Changes
None.Validation
[Red/green evidence](https://github.com/mhatipog/oai/actions/runs/38857349168) · [Cross-version CI](https://github.com/mhatipog/oai/actions/runs/38857349282)
This is a focused fix for an already documented limitation, not a claim of a newly discovered vulnerability.
Related: #7455 and the earlier unmerged PR #7528.