Repository navigation
Python: Support ag-ui-protocol 1.0 in agent-framework-ag-ui #9378
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
Markus Ecker (mme)
wants to merge
4
commits into
microsoft:main
Choose a base branch
from
mme:mme/ag-ui-protocol-1.0
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
fff0541
Python: Support ag-ui-protocol 1.0 in agent-framework-ag-ui
mme 2a34841
Merge branch 'main' into mme/ag-ui-protocol-1.0
mme ba2d486
Relay tool-result media through TOOL_CALL_RESULT and the snapshot
mme 7b294ab
Merge branch 'main' into mme/ag-ui-protocol-1.0
mme File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed in ba2d486.
_emit_tool_resultnow encodes a media-bearing result with_function_result_to_agui_contentand threads the parts through_emit_tool_result_common, so both the outwardTOOL_CALL_RESULT(unless a display payload overrides it) and the snapshot message inflow.tool_resultscarry the content parts. The approval-path events in_make_approval_tool_result_eventsdo the same, matching the snapshot messages_resolved_tool_result_snapshot_messagesalready rebuilt with parts. MCP results keep the Host-payload handling. Tests:test_agent_run_relays_tool_result_media(stub agent behindAgentFrameworkAgent) andtest_agent_relays_tool_result_media_from_an_agui_server(AGUIChatClientfed by a mock AG-UI server, wrapped inAgentandAgentFrameworkAgent).