Repository navigation
.NET: Also include citations and error details in purview checks. - #9375
Conversation
agent-framework-automation
Bot
added
documentation
github-actions
Bot
changed the title
github-actions
Bot
changed the title
There was a problem hiding this comment.
🟡 Changes recommended
Empty binary content can still bypass evaluation of a sensitive DataContent.Name.
1 open finding
What changed in this PR
Extends Purview checks to evaluate supplemental metadata across Python and .NET.
Changes:
- Submits text annotations, error details, and data names for evaluation.
- Adds tests and updates evaluation documentation.
| File | Description |
|---|---|
python/.../_processor.py |
Evaluates text annotations separately. |
python/.../test_processor.py |
Tests citation submission. |
python/.../README.md |
Documents annotation evaluation. |
dotnet/.../ScopedContentProcessor.cs |
Adds supplemental-content mapping. |
dotnet/.../ScopedContentProcessorTests.cs |
Tests supplemental metadata. |
dotnet/.../README.md |
Documents evaluated metadata. |
🧠 Review effort: Balanced
💡 Add a code-review agent skill for context-aware, tailored reviews. Learn more in the docs.
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
MAF Automated Review — Iteration 1
Result: Findings reported
Scope: full PR (1 commit(s)): 7936d9192c2b
Model: gpt-5.6-sol
Overview
The PR extends the existing per-content Purview mapping with separately addressable entries for citations and other supplemental metadata, and the new tests verify the main non-empty cases. Existing unique identifiers, sequence ordering, and fail-closed middleware behavior provide strong guardrails. One residual gap allows a zero-byte .NET data item to bypass evaluation of a non-empty filename.
Reviewed the supplied pull-request change set across correctness, security/reliability, architecture, and failure behavior.
1 verified finding remained after source verification (1 medium) across 1 file. Details are attached to the affected lines below.
Affected areas: dotnet/src/Microsoft.Agents.AI.Purview/ScopedContentProcessor.cs
Eduard van Valkenburg (eavanvalkenburg)
left a comment
Eduard van Valkenburg (eavanvalkenburg)
left a comment
There was a problem hiding this comment.
LGTM
Motivation & Context
Send further details to purview.
Description & Review Guide
Send further details to purview.
Related Issue
Fixes #
AI Assistance
AI assistance details:
Contribution Checklist
breaking changelabel (or add "[BREAKING]" to the title prefix, before or after any language prefix) — a workflow keeps the label and title prefix in sync automatically.