Skip to content

Python: Make tool-normalization documentation examples self-contained - #9333

Merged
Eduard van Valkenburg (eavanvalkenburg) merged 1 commit into
microsoft:mainfrom
BlueRaddish:fix/oct12-ms-b
Oct 16, 2026
Merged

Eduard van Valkenburg (eavanvalkenburg) merged 1 commit into
microsoft:mainfrom
BlueRaddish:fix/oct12-ms-b

Conversation

@BlueRaddish

Copy link
Copy Markdown
Contributor

Motivation & Context

The public normalize_tools and validate_tools examples reference another_tool without defining it. Copying either example raises NameError during its list demonstration.

Description & Review Guide

  • What are the major changes? Demonstrate the list form using the tool already defined in each example.
  • What is the impact of these changes? Both complete public examples run and produce a one-item list containing my_tool. Only the two docstrings change; the runtime AST is unchanged. Actual examples failed before the change and passed on Windows Python 3.11.17 and Linux Python 3.13.16 afterward. Normal scoped repository hooks passed without changing the patch.
  • What do you want reviewers to focus on? Each example remains self-contained and demonstrates both a single tool and a list without introducing another API.

Related Issue

N/A - trivial change. This removes an undefined name from two runnable public examples without changing behavior.

AI Assistance

  • No material AI assistance was used.
  • This is an AI-assisted contribution. I reviewed, understood, and verified all submitted content and accept responsibility for it.

AI assistance details: OpenAI Codex assisted with diagnosis, the focused documentation correction, verification and this description. The contributor personally reviewed and verified this change.

Contribution Checklist

  • The code builds clean without any errors or warnings
  • All unit tests pass, and I have added new tests where possible
  • The PR follows the Contribution Guidelines
  • This PR links to an agreed issue with no competing open PR, or the Related Issue section documents a trivial-change or repository-automation exception.
  • This is not a breaking change. If it is a breaking change, add the breaking change label (or add "[BREAKING]" to the title prefix, before or after any language prefix) — a workflow keeps the label and title prefix in sync automatically.

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

@agent-framework-automation agent-framework-automation Bot added the python Usage: [Issues, PRs], Target: Python label Oct 13, 2026
@eavanvalkenburg

Copy link
Copy Markdown
Member

/review

@github-actions github-actions Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

MAF Automated Review — Iteration 1

Result: No findings
Scope: full PR (1 commit(s)): 522c3702d2b2
Model: gpt-5.6-sol

Overview

The PR makes both public tool-normalization examples self-contained by replacing the undefined another_tool reference with the already-defined my_tool. The implementation contract and focused normalization tests confirm that a singleton list is accepted and preserves the demonstrated tool, while the change remains confined to docstrings. No publishable risk was established.

Reviewed the supplied pull-request change set across correctness, security/reliability, architecture, and failure behavior.
No publishable findings remained after source verification for this scope.

Merged via the queue into microsoft:main with commit b1c582e Oct 16, 2026
49 of 50 checks passed

This branch was previously deployed

1 inactive deployment
github-app-auth — 522c3702 Deployed Oct 13, 2026 by BlueRaddish via team_check #6686
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

python Usage: [Issues, PRs], Target: Python

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants