Skip to content

Document that Python and .NET changes go in separate PRs #9168

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Mark Licata (marklicata) wants to merge 1 commit into from
Closed

Document that Python and .NET changes go in separate PRs #9168

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions CONTRIBUTING.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -88,6 +88,8 @@ DON'Ts:
- **DON'T** submit PRs that alter licensing related files or headers. If you believe
there's a problem with them, file an issue and we'll be happy to discuss it.
- **DON'T** make new APIs without filing an issue and discussing with us first.
- **DON'T** combine Python and .NET changes in a single pull request. Open a
separate PR for each language, even when the change is the same feature in both.

### Breaking Changes

Expand Down Expand Up @@ -197,6 +199,9 @@ We use and recommend the following workflow:
5. Add new tests corresponding to your change, if applicable.
6. Run the relevant scripts in [the section below](#development-setup) to ensure that your build is clean and all tests are passing.
7. Create a PR against the repository's **main** branch.
- Keep each PR to a single language: changes under `python/` and changes under
`dotnet/` go in separate PRs. Prefix the title with `Python:` or `.NET:`, and
link the related PR in the other language from the description.
- State in the description what issue or improvement your change is addressing.
- Verify that all the Continuous Integration checks are passing.
8. Address feedback from the code maintainers. Reply to every review comment with
Expand Down
Loading