Skip to content

Python: Ignore braces inside strings when parsing the Magentic progress ledger #9089

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Eduard van Valkenburg (eavanvalkenburg) merged 1 commit into from
Oct 12, 2026
Merged

Python: Ignore braces inside strings when parsing the Magentic progress ledger #9089

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 13 additions & 1 deletion python/packages/orchestrations/agent_framework_orchestrations/_magentic.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -427,8 +427,20 @@ def _extract_json(text: str) -> dict[str, Any]:
raise ValueError("No JSON object found.")
depth = 0
end = None
in_string = False
escaped = False
for i, ch in enumerate(text[start:], start=start):
if ch == "{":
# Braces inside string values, such as code in an instruction, do not count.
if in_string:
if escaped:
escaped = False
elif ch == "\\":
escaped = True
elif ch == '"':
in_string = False
elif ch == '"':
in_string = True
elif ch == "{":
depth += 1
elif ch == "}":
depth -= 1
Expand Down
14 changes: 14 additions & 0 deletions python/packages/orchestrations/tests/test_magentic.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1456,4 +1456,18 @@ def test_extract_json_reads_first_fenced_object(text: str) -> None:
assert _extract_json(text)["is_request_satisfied"] is True


@pytest.mark.parametrize(
"text",
[
'{"is_request_satisfied": true, "answer": "The f-string is missing its closing } so add it."}',
'Ledger: {"is_request_satisfied": true, "answer": "Open the block with { and keep going"} done',
'{"is_request_satisfied": true, "answer": "Escaped quote \\" then a brace }"}',
],
)
def test_extract_json_ignores_braces_inside_strings(text: str) -> None:
from agent_framework_orchestrations._magentic import _extract_json # type: ignore

assert _extract_json(text)["is_request_satisfied"] is True


# endregion
Loading