Repository navigation
Python: Update canonical document status after restored upload retries - #9085
Merged
Eduard van Valkenburg (eavanvalkenburg) merged 1 commit intoOct 12, 2026
Conversation
LI (ktz03)
temporarily deployed
to
github-app-auth
October 5, 2026 20:50 — with
GitHub Actions
Inactive
Contributor
There was a problem hiding this comment.
Copilot review overview
🟢 Approval recommended
The targeted fix preserves fallback behavior and has comprehensive regression coverage.
Review effort: Balanced
Findings: None
What changed in this PR
Fixes restored upload retries so they update the canonical document state.
Changes:
- Resolves queued uploads against the current document mapping.
- Adds six regression cases covering success, failure, timeout, restoration, and fallback behavior.
| File | Description |
|---|---|
_context_provider.py |
Uses the canonical document entry during retries. |
test_context_provider.py |
Adds focused retry and restoration tests. |
💡 Add a code-review agent skill for context-aware, tailored reviews. Learn more in the docs.
LI (ktz03)
temporarily deployed
to
github-app-auth
October 5, 2026 21:40 — with
GitHub Actions
Inactive
LI (ktz03)
marked this pull request as ready for review
October 9, 2026 02:34
LI (ktz03)
temporarily deployed
to
github-app-auth
October 9, 2026 02:34 — with
GitHub Actions
Inactive
Eduard van Valkenburg (eavanvalkenburg)
approved these changes
Oct 12, 2026
This branch was previously deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation & Context
A pending Content Understanding vector-store upload retains a second reference to its document entry. Restoring the session reconstructs separate mappings, so a later upload success or failure leaves the canonical document and
list_documentsstuck atuploadingafter the queue is cleared.Description & Review Guide
DocumentStatuscodec. The existing unconfigured-codec rejection and compatibleto_dict()warnings remain unchanged. No live Azure upload, authentication, indexing, or model run was performed.Related Issue
Fixes #9084
Contribution Checklist
breaking changelabel (or add "[BREAKING]" to the title prefix, before or after any language prefix) — a workflow keeps the label and title prefix in sync automatically.