Repository navigation
Python: fix(ag-ui): read tool_call_id on TOOL_CALL_RESULT events - #8734
Merged
Eduard van Valkenburg (eavanvalkenburg) merged 1 commit intoSep 28, 2026
Conversation
Anish Mehta (anishmehta24)
temporarily deployed
to
github-app-auth
September 24, 2026 17:31 — with
GitHub Actions
Inactive
Anish Mehta (anishmehta24)
temporarily deployed
to
github-app-auth
September 24, 2026 17:31 — with
GitHub Actions
Inactive
Eduard van Valkenburg (eavanvalkenburg)
approved these changes
Sep 28, 2026
This branch was previously deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation & Context
AGUIEventConverter._handle_tool_call_resultonly readtoolCallId. The other tool call handlers go through_get_tool_call_id, which accepts bothtoolCallIdandtool_call_id, so a result sent with the snake_case spelling came back with an emptycall_idand was no longer linked to its call:Description & Review Guide
_get_tool_call_id(event)in_handle_tool_call_resultlike the other handlers.tool_call_idkeep their call id.toolCallIdstill takes precedence.Related Issue
No existing issue.
Contribution Checklist
Test:
test_tool_call_result_event_snake_case_idintests/ag_ui/test_event_converters.py; it fails on main. The file passes and the repo's pre-commit checks are clean.