Repository navigation
Python: fix(core): accept a bare container type as an edge target for a parameterized output - #8731
Merged
Eduard van Valkenburg (eavanvalkenburg) merged 5 commits intoOct 9, 2026
Conversation
… a parameterized output
Anish Mehta (anishmehta24)
temporarily deployed
to
github-app-auth
September 24, 2026 17:12 — with
GitHub Actions
Inactive
Anish Mehta (anishmehta24)
temporarily deployed
to
github-app-auth
September 24, 2026 17:12 — with
GitHub Actions
Inactive
Anish Mehta (anishmehta24)
temporarily deployed
to
github-app-auth
September 29, 2026 04:36 — with
GitHub Actions
Inactive
Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
Anish Mehta (anishmehta24)
requested a review
from sophia-ramsey
as a code owner
October 4, 2026 13:21
Anish Mehta (anishmehta24)
temporarily deployed
to
github-app-auth
October 4, 2026 13:21 — with
GitHub Actions
Inactive
Anish Mehta (anishmehta24)
temporarily deployed
to
github-app-auth
October 5, 2026 17:09 — with
GitHub Actions
Inactive
Anish Mehta (anishmehta24)
temporarily deployed
to
github-app-auth
October 6, 2026 22:54 — with
GitHub Actions
Inactive
Contributor
Author
|
Eduard van Valkenburg (@eavanvalkenburg) also fixed the mypy error in the test, ready for another look. |
Eduard van Valkenburg (eavanvalkenburg)
approved these changes
Oct 7, 2026
3 tasks done
This branch was previously deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation & Context
A handler that takes a plain
list(ordict,tuple,Sequence) can't receive a parameterized output from an upstream executor. The workflow fails to build:is_type_compatiblecomparesget_origin(list[str])(list) withget_origin(list)(None) in Case 5 and returns False before the "one side is untyped, assume compatible" rule in Case 6 is reached. The runtime check already accepts the message. The reverse,list -> list[str], fails the same way.Description & Review Guide
issubclass.list[str] -> list,dict[str, int] -> dict,list[int] -> Sequenceandlist -> list[str]are now compatible;list[str] -> dictstill isn't.list[Message] -> Sequence[Message](both parameterized, different containers) is still rejected by Case 5. I left that out to keep this small.Related Issue
No existing issue.
Contribution Checklist
Tests: a unit case in
test_typing_utils.pyand a workflow build intest_validation.py; both fail on main.pytest packages/core/tests/workflowpasses, and ruff and the repo's pre-commit checks are clean.