Skip to content

Python: perf(core): fast path empty incoming messages in filter_new_messages - #8697

Closed
Manohar Paturi (ManoharPaturi) wants to merge 1 commit into
microsoft:mainfrom
ManoharPaturi:fix/filter-new-messages-empty-fast-path
Closed

Manohar Paturi (ManoharPaturi) wants to merge 1 commit into
microsoft:mainfrom
ManoharPaturi:fix/filter-new-messages-empty-fast-path

Conversation

@ManoharPaturi

Copy link
Copy Markdown
Contributor

In _sessions.py, filter_new_messages determines which messages in an incoming turn are new relative to existing history.

When incoming was empty while existing contained messages, the function still computed hashes for every message in existing history, allocated existing_set, and evaluated slice comparisons before returning an empty list. In sessions with longer conversation histories, this caused unnecessary serialization and hashing overhead on empty turns.

This PR adds an immediate if not incoming: return [] early exit to filter_new_messages. I also added unit tests covering this function in test_sessions.py.

Signed-off-by: Manohar Paturi <186662190+ManoharPaturi@users.noreply.github.com>

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

@agent-framework-automation agent-framework-automation Bot added the python Usage: [Issues, PRs], Target: Python label Sep 23, 2026
@github-actions github-actions Bot changed the title perf(core): fast path empty incoming messages in filter_new_messages Python: perf(core): fast path empty incoming messages in filter_new_messages Sep 23, 2026
@eavanvalkenburg

Copy link
Copy Markdown
Member

Thank you for proposing this change. I am closing this PR for now because it has no linked issue, and I could not find an issue covering this specific problem. Our contribution guidelines ask contributors to create or reuse an issue and discuss the approach before nontrivial changes (with an exception for trivial changes). The repository PR template asks for Motivation & Context, Description & Review Guide, a Related Issue linked with a closing keyword such as Fixes #123, and the contribution checklist; it notes that PRs without an issue link may be closed. This description does not follow that template. Please open or identify an issue, agree on the approach with the maintainers, then submit an updated PR using the template and linking the issue. Thanks.

This branch was previously deployed

1 inactive deployment
github-app-auth — 78d22d9a Deployed Sep 23, 2026 by ManoharPaturi via team_check #5168
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

python Usage: [Issues, PRs], Target: Python

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants