Skip to content

Python: Add a disposable fix-ci smoke test [do not review] - #8666

Closed
Evan Mattson (moonbox3) wants to merge 3 commits into
microsoft:mainfrom
moonbox3:codex/fix-ci-smoke-test
Closed

Evan Mattson (moonbox3) wants to merge 3 commits into
microsoft:mainfrom
moonbox3:codex/fix-ci-smoke-test

Conversation

@moonbox3

@moonbox3 Evan Mattson (moonbox3) commented Sep 23, 2026 •

Copy link
Copy Markdown
Contributor

Motivation & Context

Provide a disposable pull request for validating the maintainer-triggered /fix-ci workflow end to end. The added private module is clean under Ruff but contains one deterministic Pyright return-type error attributable to this PR.

Description & Review Guide

  • What are the major changes? Adds one temporary private core module whose object value is returned from a function annotated to return str.
  • What is the impact of these changes? This PR is a smoke-test fixture and is intended to be closed after /fix-ci repairs the branch successfully.
  • What do you want reviewers to focus on? No product review is requested. Confirm that Package Checks (3.11) reports reportReturnType, then use /fix-ci to exercise automated repair and branch publication.

Related Issue

None.

Contribution Checklist

  • The code builds clean without any errors or warnings
  • All unit tests pass, and I have added new tests where possible
  • The PR follows the Contribution Guidelines
  • This PR is linked to an issue and there is no other open PR for this issue (see Related Issue above).
  • This is not a breaking change.

Copilot AI balanced review requested due to automatic review settings September 23, 2026 00:19
@agent-framework-automation agent-framework-automation Bot added the python Usage: [Issues, PRs], Target: Python label Sep 23, 2026

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot review overview

🟡 Changes recommended

The intentional Ruff failures must be repaired by /fix-ci before the branch can satisfy merge checks.

Get a fresh assessment by requesting another Copilot review.

Review effort: Balanced
Findings: None

What changed in this PR

Adds a disposable Python test fixture to validate the maintainer-triggered /fix-ci workflow.

Changes:

  • Adds a passing smoke test with intentional Ruff formatting and lint violations.
File Description
python/​packages/​core/​tests/​test_fix_ci_smoke.py Adds the temporary malformed smoke-test fixture.

💡 Add a code-review agent skill for context-aware, tailored reviews. Learn more in the docs.

@github-actions github-actions Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

MAF Automated Review — Iteration 1

Result: Findings reported
Scope: full PR (1 commit(s)): 728f93a2e1e9
Model: gpt-5.6-sol-fast

Overview

The PR adds an isolated, deterministic arithmetic test and does not affect product behavior, public APIs, persistent state, or security boundaries. Test discovery and runtime behavior are well constrained, but the chosen whitespace violations are automatically repaired by the repository's mutating Ruff tasks, so the fixture does not produce the CI failure required to exercise /fix-ci.

Reviewed the supplied pull-request change set across correctness, security/reliability, architecture, and failure behavior.
1 verified finding remained after source verification (1 medium) across 1 file. Details are attached to the affected lines below.

Affected areas: python/packages/core/tests/test_fix_ci_smoke.py

@moonbox3 Evan Mattson (moonbox3) changed the title Python: Add a disposable fix-ci smoke test Python: Add a disposable fix-ci smoke test [do not review] Sep 23, 2026
@moonbox3

Copy link
Copy Markdown
Contributor Author

/fix-ci

@agent-framework-automation

Copy link
Copy Markdown

I don’t have permission to push changes to this PR’s fork branch. No changes were made.

This branch was previously deployed

1 inactive deployment
github-app-auth — ae9effd6 Deployed Sep 23, 2026 by moonbox3 via add_label #23605
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

python Usage: [Issues, PRs], Target: Python

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants