Repository navigation
Python: preserve Unicode paths in in-memory file discovery - #8630
Merged
Eduard van Valkenburg (eavanvalkenburg) merged 1 commit intoSep 22, 2026
Conversation
Sunhy (Shy7777)
temporarily deployed
to
github-app-auth
September 22, 2026 07:39 — with
GitHub Actions
Inactive
Sunhy (Shy7777)
temporarily deployed
to
github-app-auth
September 22, 2026 07:39 — with
GitHub Actions
Inactive
Sunhy (Shy7777)
temporarily deployed
to
github-app-auth
September 22, 2026 07:39 — with
GitHub Actions
Inactive
Sunhy (Shy7777)
temporarily deployed
to
github-app-auth
September 22, 2026 07:39 — with
GitHub Actions
Inactive
Sunhy (Shy7777)
marked this pull request as ready for review
September 22, 2026 07:40
Sunhy (Shy7777)
temporarily deployed
to
github-app-auth
September 22, 2026 07:40 — with
GitHub Actions
Inactive
Eduard van Valkenburg (eavanvalkenburg)
approved these changes
Sep 22, 2026
Eduard van Valkenburg (eavanvalkenburg)
left a comment
Member
There was a problem hiding this comment.
Sunhy (@Shy7777) Reviewed the complete diff; no high-confidence issues found.
This branch was previously deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation & Context
An agent that stores
İstanbul/notes.mdinInMemoryAgentFileStorecannot reliably discover and read it back: the directory listing reportsİstanbul/, and listing or searching inside it returnsotes.md. The lookup key uses lowercase text, whereİexpands to two characters, but the original display path is sliced using offsets from that key.Description & Review Guide
Related Issue
Fixes #8623
Contribution Checklist
breaking changelabel (or add "[BREAKING]" to the title prefix, before or after any language prefix) — a workflow keeps the label and title prefix in sync automatically.The six regression cases fail before the fix. The file-access and file-memory suites pass with the fix: 148 passed and 2 Windows-only skips. The complete repository unit suite was not run. The core package builds, the configured hooks pass, and source/test type checks pass for the changed files. The related tests emit the existing experimental-feature warning for
AgentFileStore.