Repository navigation
Python: preserve Redis memory vectorizer data types - #8629
Merged
Eduard van Valkenburg (eavanvalkenburg) merged 1 commit intoSep 22, 2026
Merged
Eduard van Valkenburg (eavanvalkenburg) merged 1 commit into
Eduard van Valkenburg (eavanvalkenburg) merged 1 commit into
Conversation
Sunhy (Shy7777)
temporarily deployed
to
github-app-auth
September 22, 2026 07:37 — with
GitHub Actions
Inactive
Sunhy (Shy7777)
temporarily deployed
to
github-app-auth
September 22, 2026 07:37 — with
GitHub Actions
Inactive
Sunhy (Shy7777)
temporarily deployed
to
github-app-auth
September 22, 2026 07:38 — with
GitHub Actions
Inactive
Sunhy (Shy7777)
temporarily deployed
to
github-app-auth
September 22, 2026 07:38 — with
GitHub Actions
Inactive
Sunhy (Shy7777)
marked this pull request as ready for review
September 22, 2026 07:39
Sunhy (Shy7777)
temporarily deployed
to
github-app-auth
September 22, 2026 07:39 — with
GitHub Actions
Inactive
Eduard van Valkenburg (eavanvalkenburg)
approved these changes
Sep 22, 2026
Eduard van Valkenburg (eavanvalkenburg)
left a comment
Member
There was a problem hiding this comment.
Sunhy (@Shy7777) Reviewed the complete diff; no high-confidence issues found.
This branch was previously deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation & Context
When
RedisContextProvideris used with afloat16,float64, orbfloat16vectorizer, its memory writes are still encoded asfloat32. The resulting buffers disagree with the index schema and the query encoding. For example, a two-dimensionalfloat64field receives 8 bytes instead of 16, so the stored bytes cannot represent the intended vector.Description & Review Guide
array_to_bufferhelper with the configured vectorizer data type when storing memories. Add a regression test throughafter_run()forfloat16,float32,float64, andbfloat16, checking both input and response embeddings against the schema, byte lengths, and decoded values.float32behavior remains unchanged, and no public API or dependency changes are needed.bfloat16without a separate encoding implementation.Related Issue
Fixes #8624
Contribution Checklist
breaking changelabel (or add "[BREAKING]" to the title prefix, before or after any language prefix) — a workflow keeps the label and title prefix in sync automatically.