Repository navigation
Python: Forward invocation kwargs during nested workflow cancellation - #8602
Merged
Eduard van Valkenburg (eavanvalkenburg) merged 5 commits intoOct 1, 2026
Conversation
WhaleTech (ryo-whaletech)
temporarily deployed
to
github-app-auth
September 21, 2026 16:35 — with
GitHub Actions
Inactive
WhaleTech (ryo-whaletech)
temporarily deployed
to
github-app-auth
September 21, 2026 16:35 — with
GitHub Actions
Inactive
WhaleTech (ryo-whaletech)
temporarily deployed
to
github-app-auth
September 21, 2026 16:35 — with
GitHub Actions
Inactive
WhaleTech (ryo-whaletech)
temporarily deployed
to
github-app-auth
September 21, 2026 16:35 — with
GitHub Actions
Inactive
Contributor
There was a problem hiding this comment.
Copilot review overview
🟡 Changes recommended
The stale omitted-channel clearing behavior needs targeted regression coverage.
Get a fresh assessment by requesting another Copilot review.
Review effort: Balanced
Findings: 1
Open (1)
What changed in this PR
Forwards request-scoped invocation kwargs into nested workflow cancellation.
Changes:
- Extracts shared child-kwargs resolution logic.
- Adds nested cancellation regression coverage.
| File | Description |
|---|---|
_workflow_executor.py |
Forwards both kwargs channels during cancellation. |
test_workflow_kwargs.py |
Tests replacement kwargs in child cancellation. |
💡 Add a code-review agent skill for context-aware, tailored reviews. Learn more in the docs.
WhaleTech (ryo-whaletech)
temporarily deployed
to
github-app-auth
September 21, 2026 17:50 — with
GitHub Actions
Inactive
WhaleTech (ryo-whaletech)
temporarily deployed
to
github-app-auth
September 21, 2026 19:16 — with
GitHub Actions
Inactive
Member
|
WhaleTech (@ryo-whaletech) This branch currently conflicts with |
WhaleTech (ryo-whaletech)
temporarily deployed
to
github-app-auth
September 30, 2026 00:26 — with
GitHub Actions
Inactive
WhaleTech (ryo-whaletech)
marked this pull request as ready for review
September 30, 2026 00:45
WhaleTech (ryo-whaletech)
temporarily deployed
to
github-app-auth
September 30, 2026 00:45 — with
GitHub Actions
Inactive
Contributor
Author
|
Eduard van Valkenburg (@eavanvalkenburg) Thanks for the heads-up — I’ve updated the branch with current |
WhaleTech (ryo-whaletech)
requested a review
from sophia-ramsey
as a code owner
September 30, 2026 14:09
WhaleTech (ryo-whaletech)
temporarily deployed
to
github-app-auth
September 30, 2026 14:09 — with
GitHub Actions
Inactive
WhaleTech (ryo-whaletech)
temporarily deployed
to
github-app-auth
September 30, 2026 14:10 — with
GitHub Actions
Inactive
Eduard van Valkenburg (eavanvalkenburg)
approved these changes
Oct 1, 2026
This branch was previously deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Motivation & Context
Cancelling a propagated child request with replacement function-invocation or client kwargs must apply those active settings to the nested continuation. Previously, the wrapper forwarded only runtime tools and the child retained stale kwargs. Explicit replacements must also remain distinct from omitted channels when scoping removes every replacement key.
Description & Review Guide
Related Issue
Fixes #8601
Related: merged PR #8596 scopes invocation kwargs by executor graph. This change preserves those boundaries while addressing cancellation continuation. A pre-publication search found no other open PR addressing #8601.
Contribution Checklist
breaking changelabel (or add "[BREAKING]" to the title prefix, before or after any language prefix) — a workflow keeps the label and the title prefix in sync automatically.