Repository navigation
Python: Gate sequential workflow output on approval - #8595
Conversation
There was a problem hiding this comment.
Copilot review overview
🟢 Approval recommended
The focused change resolves premature output exposure with appropriate regression coverage.
Review effort: Balanced
Findings: None
What changed in this PR
Gates sequential workflow output until request-info approval completes.
Changes:
- Limits output to the request-info executor.
- Verifies paused runs expose no unapproved output.
- Preserves approved terminal responses.
| File | Description |
|---|---|
| python/packages/orchestrations/tests/test_sequential.py | Adds regression coverage for approval-gated output. |
| python/packages/orchestrations/agent_framework_orchestrations/_orchestration_request_info.py | Restricts output to approved responses. |
💡 Add a code-review agent skill for context-aware, tailored reviews. Learn more in the docs.
There was a problem hiding this comment.
MAF Automated Review — Iteration 1
Result: No findings
Scope: full PR (1 commit(s)): cc1523b08a19
Model: gpt-5.6-sol-fast
Overview
The PR structurally prevents the inner agent executor from surfacing unapproved responses while preserving those responses in request-info events for review. Separate intermediate and terminal approval executors retain the expected AgentExecutorResponse chaining and terminal AgentResponse contract, and the regression test covers initial suspension, repeated approval pauses, and final approved output. No publishable Critical, High, or Medium issue was established.
Reviewed the supplied pull-request change set across correctness, security/reliability, architecture, and failure behavior.
No publishable findings remained after source verification for this scope.
Motivation & Context
Sequential workflows using
with_request_info()can surface an agent response as a normal workflow output while that response is still awaiting human review. Applications that publish output events can therefore expose content before the request-info approval step completes.The response remains available to the reviewer through the request-info event, while caller-facing workflow output should represent an approved response.
Description & Review Guide
AgentResponsecontract.Related Issue
Fixes #8594
Contribution Checklist
breaking changelabel (or add "[BREAKING]" to the title prefix, before or after any language prefix) — a workflow keeps the label and title prefix in sync automatically.