Repository navigation
Python: Clarify Redis context retrieval scope - #8584
Eduard van Valkenburg (eavanvalkenburg) merged 2 commits into
Conversation
There was a problem hiding this comment.
Copilot review overview
🟡 Changes recommended
The documentation must clarify that at least one scope identifier is required.
Get a fresh assessment by requesting another Copilot review.
Review effort: Balanced
Findings: 1
What changed in this PR
Clarifies Redis context retrieval scope across sessions and identifiers.
Changes:
- Documents conjunctive filtering for non-empty scope IDs.
- Explains that omitted IDs leave that dimension unfiltered.
| File | Description |
|---|---|
python/packages/redis/agent_framework_redis/_context_provider.py |
Clarifies retrieval scope semantics. |
💡 Add a code-review agent skill for context-aware, tailored reviews. Learn more in the docs.
There was a problem hiding this comment.
MAF Automated Review — Iteration 1
Result: No findings
Scope: full PR (1 commit(s)): 568b9980b270
Model: gpt-5.6-sol-fast
Overview
This documentation-only change describes the provider's existing cross-session retrieval model and advises callers to supply trusted isolation identifiers. The implementation and tests confirm that configured identifiers are combined conjunctively, omitted dimensions are not filtered, and at least one scope identifier is enforced before reads or writes. No Critical, High, or Medium defect was established.
Reviewed the supplied pull-request change set across correctness, security/reliability, architecture, and failure behavior.
No publishable findings remained after source verification for this scope.
* Python: Clarify Redis context retrieval scope * Python: Document required Redis context scope

Motivation & Context
RedisContextProvidersupports cross-session memory retrieval, but its public docstring did not explain how optional scope identifiers affect filtering. Callers need to know that omitted identifiers leave that dimension unfiltered so they can provide every intended isolation boundary.Description & Review Guide
application_id,agent_id, anduser_idconjunctively, and does not filter on omitted identifiers.Related Issue
Fixes #8583
Contribution Checklist
breaking changelabel (or add "[BREAKING]" to the title prefix, before or after any language prefix) — a workflow keeps the label and the title prefix in sync automatically.