Repository navigation
Python: Preserve empty hosted MCP allowlists - #8576
Eduard van Valkenburg (eavanvalkenburg) merged 1 commit into
Conversation
There was a problem hiding this comment.
Copilot review overview
🟢 Approval recommended
The focused behavior change is documented and comprehensively covered through request serialization.
Review effort: Balanced
Findings: None
What changed in this PR
Preserves explicitly empty hosted MCP allowed_tools lists across OpenAI and Foundry request serialization.
Changes:
- Distinguishes
Nonefrom empty allowlists. - Documents the behavior.
- Adds construction and wire-format regression tests.
| File | Description |
|---|---|
python/packages/openai/agent_framework_openai/_chat_client.py |
Preserves empty OpenAI MCP allowlists. |
python/packages/openai/tests/openai/test_openai_chat_client.py |
Tests OpenAI configuration and serialization. |
python/packages/foundry/agent_framework_foundry/_chat_client.py |
Preserves empty Foundry MCP allowlists. |
python/packages/foundry/tests/foundry/test_foundry_chat_client.py |
Tests Foundry URL and connection configurations. |
💡 Add a code-review agent skill for context-aware, tailored reviews. Learn more in the docs.
There was a problem hiding this comment.
MAF Automated Review — Iteration 1
Result: No findings
Scope: full PR (1 commit(s)): c0afb6c3257f
Model: gpt-5.6-sol-fast
Overview
The PR correctly distinguishes an omitted hosted MCP allowlist from an explicitly empty one in both OpenAI and Foundry configuration helpers. Parameterized tests cover omitted, empty, and nonempty values through actual SDK request serialization, while preserving Foundry URL/project-connection and header precedence. No publishable Critical, High, or Medium defect was established in the changed behavior.
Reviewed the supplied pull-request change set across correctness, security/reliability, architecture, and failure behavior.
No publishable findings remained after source verification for this scope.
Motivation & Context
Preserve explicitly supplied empty
allowed_toolslists when constructing hosted MCP tool configurations.Description & Review Guide
Nonefrom an empty list, and document the distinction.Related Issue
N/A.
Contribution Checklist
breaking changelabel (or add "[BREAKING]" to the title prefix, before or after a language prefix) — a workflow keeps the label and title prefix in sync automatically.