Repository navigation
Python: Isolate Foundry Hosting local test state - #8409
Merged
Eduard van Valkenburg (eavanvalkenburg) merged 1 commit intoSep 16, 2026
Conversation
WhaleTech (ryo-whaletech)
temporarily deployed
to
github-app-auth
September 15, 2026 21:06 — with
GitHub Actions
Inactive
WhaleTech (ryo-whaletech)
temporarily deployed
to
github-app-auth
September 15, 2026 21:06 — with
GitHub Actions
Inactive
WhaleTech (ryo-whaletech)
temporarily deployed
to
github-app-auth
September 15, 2026 21:07 — with
GitHub Actions
Inactive
WhaleTech (ryo-whaletech)
temporarily deployed
to
github-app-auth
September 15, 2026 21:07 — with
GitHub Actions
Inactive
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
The fixture provides function-scoped isolation while preserving explicit root overrides and automatic environment restoration.
Pull request overview
Isolates Foundry Hosting test persistence to prevent cross-test and cross-worker state interference.
Changes:
- Adds an autouse fixture assigning each test a temporary AgentServer state root.
- Adds a regression test verifying the root is test-scoped.
File summaries
| File | Description |
|---|---|
python/packages/foundry_hosting/tests/conftest.py |
Configures per-test local state isolation. |
python/packages/foundry_hosting/tests/test_state_store.py |
Verifies the isolated state-root contract. |
Review details
- Files reviewed: 2/2 changed files
- Comments generated: 0
- Review effort level: Balanced
💡 Add a code-review agent skill for context-aware, tailored reviews. Learn more in the docs.
WhaleTech (ryo-whaletech)
marked this pull request as ready for review
September 15, 2026 21:15
WhaleTech (ryo-whaletech)
temporarily deployed
to
github-app-auth
September 15, 2026 21:16 — with
GitHub Actions
Inactive
Eduard van Valkenburg (eavanvalkenburg)
approved these changes
Sep 16, 2026
Eduard van Valkenburg (eavanvalkenburg)
left a comment
Member
There was a problem hiding this comment.
Reviewed the complete diff and found no actionable issues. All reported checks for the current head are green.
This branch was previously deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation & Context
Foundry Hosting tests exercise local AgentServer-backed persistence. Independent pytest execution contexts can share its JSON state root, allowing one test's write to remove another test's response-chain session.
Description & Review Guide
Related Issue
Fixes #8408
Contribution Checklist
breaking changelabel (or add "[BREAKING]" to the title prefix, before or after any language prefix) — a workflow keeps the label and title prefix in sync automatically.