Repository navigation
Python: Restrict argument labels against owned input integrity - #8394
Conversation
There was a problem hiding this comment.
🟢 Approval recommended
No unresolved blocking issues were identified.
Pull request overview
Updates Python FIDES label tracking so argument labels restrict, but do not promote, fallback integrity.
Changes:
- Derives fallback integrity from owned labels or configured defaults.
- Adds regression coverage for precedence, quarantine, confidentiality, and taint.
- Updates the FIDES developer guide.
File summaries
| File | Description |
|---|---|
python/samples/02-agents/security/FIDES_DEVELOPER_GUIDE.md |
Documents revised label propagation rules. |
python/packages/core/tests/test_security.py |
Adds comprehensive regression coverage. |
python/packages/core/agent_framework/security.py |
Implements restricted fallback integrity calculation. |
Review details
- Files reviewed: 3/3 changed files
- Comments generated: 0
- Review effort level: Lite (auto)
Note
Copilot is running an experiment and ran this review at Lite.
💡 Add a code-review agent skill for context-aware, tailored reviews. Learn more in the docs.
There was a problem hiding this comment.
MAF Automated Review — Iteration 1
Result: No findings
Scope: full PR (1 commit(s)): 8b4f94eee860
Model: gpt-5.6-sol-fast
Overview
The PR hardens tier-3 result labeling by deriving integrity from owned resolved references or the configured default and allowing argument labels only to restrict that baseline. Owner-aware resolution, restrictive label combination, explicit source-integrity precedence, and the new argument-shape and precedence matrices provide strong guards around the changed behavior. No PR-introduced Critical, High, or Medium defect was established.
Reviewed the supplied pull-request change set across correctness, security/reliability, architecture, and failure behavior.
No publishable findings remained after source verification for this scope.
Motivation & Context
Updates tier-3 result labeling in
LabelTrackingFunctionMiddleware.Description & Review Guide
default_integritywhen no references resolve. Combine argument-label restrictions with that baseline. Update the developer guide and add regression coverage.source_integrityprecedence, owned-reference inheritance, confidentiality propagation, and principal handling are unchanged.Related Issue
N/A — no linked public issue.
Contribution Checklist
breaking changelabel (or add "[BREAKING]" to the title prefix, before or after any language prefix) — a workflow keeps the label and title prefix in sync automatically.