Repository navigation
Python: Clarify Cosmos history provider storage scope - #8391
Conversation
There was a problem hiding this comment.
🟢 Approval recommended
The documentation accurately reflects the existing storage-selection behavior without changing runtime APIs.
Pull request overview
Clarifies how Cosmos-backed conversation histories are selected and shared across provider instances.
Changes:
- Documents account, database, container, session, and source selectors.
- Clarifies authorization responsibilities and the shared default
source_id.
File summaries
| File | Description |
|---|---|
python/packages/azure-cosmos/agent_framework_azure_cosmos/_history_provider.py |
Expands provider and parameter documentation. |
Review details
- Files reviewed: 1/1 changed files
- Comments generated: 0
- Review effort level: Balanced
💡 Add a code-review agent skill for context-aware, tailored reviews. Learn more in the docs.
There was a problem hiding this comment.
MAF Automated Review — Iteration 1
Result: No findings
Scope: full PR (1 commit(s)): 27394410be17
Model: gpt-5.6-sol-fast
Overview
This documentation-only change accurately explains that Cosmos account, database, container, session_id, and source_id collectively select persisted history, while authentication and authorization remain application responsibilities. The implementation and tests confirm that reads, writes, and clearing use the documented selectors, empty session IDs cannot accidentally resume history, and the default source ID is shared across instances. No publishable correctness, compatibility, architectural, or security issue was established.
Reviewed the supplied pull-request change set across correctness, security/reliability, architecture, and failure behavior.
No publishable findings remained after source verification for this scope.
Motivation & Context
Clarify how
CosmosHistoryProviderselects persisted conversation history when applications share Cosmos DB storage or resume conversations across provider instances.Description & Review Guide
source_idis shared across instances.Related Issue
N/A — small documentation clarification; the contribution guidelines allow trivial changes without an issue.
Contribution Checklist
breaking changelabel (or add "[BREAKING]" to the title prefix, before or after any language prefix) — a workflow keeps the label and title prefix in sync automatically.