Repository navigation
Preserve inbound A2A message role instead of hardcoding assistant - #1122
Open
PratikDhanave (PratikDhanave) wants to merge 4 commits into
Open
PratikDhanave (PratikDhanave) wants to merge 4 commits into
PratikDhanave (PratikDhanave) wants to merge 4 commits into
Conversation
The client inbound path hardcoded message.RoleAssistant for A2A messages and task-status messages, discarding the actual A2A role. A peer message with the user role was reported as assistant. Map the role via a shared agentRole helper (agent -> assistant, otherwise user), matching the hosting-side toAgentMessage and the Python client. Artifacts carry no role and stay assistant.
PratikDhanave (PratikDhanave)
requested a review
from a team
as a code owner
September 20, 2026 04:30
github-actions
Bot
added
area:provider
Contributor
There was a problem hiding this comment.
Copilot review overview
🟡 Changes recommended
Streaming task status messages can still report inbound user roles as assistant.
Get a fresh assessment by requesting another Copilot review.
Review effort: Lite
Findings: 1
Open (2)
What changed in this PR
Preserves inbound A2A message roles when converting responses into framework messages.
Changes:
- Added shared A2A-to-framework role mapping.
- Applied role preservation to messages and task-status updates.
- Added a user-role response test.
| File | Description |
|---|---|
provider/a2aprovider/a2a.go |
Adds role mapping for inbound responses. |
provider/a2aprovider/a2a_test.go |
Tests preservation of user-role messages. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
| role := message.RoleAssistant | ||
| if e.Status.Message != nil { | ||
| messageID = e.Status.Message.ID | ||
| role = agentRole(e.Status.Message.Role) |
Comment on lines
+303
to
+305
| // A response message carrying the A2A user role must map to RoleUser, not be | ||
| // hardcoded to assistant, matching the Python client. | ||
| func TestRunPreservesInboundUserRole(t *testing.T) { |
github-actions
Bot
added
kind:code
This comment has been minimized.
This comment has been minimized.
github-actions
Bot
added
the
parity-approved
Add a role assertion for the input-required task-status message path (yieldTask) so the user-role mapping cannot regress, and restore the TestRunWithValidUserMessage doc comment to its own test.
github-actions
Bot
added
size:large
This comment has been minimized.
This comment has been minimized.
…e-mapping # Conflicts: # go.mod # go.sum # provider/a2aprovider/a2a.go
github-actions
Bot
added
size:medium
This comment has been minimized.
This comment has been minimized.
github-actions
Bot
removed
the
kind:dependencies
Quim Muntal (qmuntal)
approved these changes
Oct 5, 2026
Quim Muntal (qmuntal)
enabled auto-merge
October 5, 2026 05:30
github-merge-queue
Bot
removed this pull request from the merge queue due to a conflict with the base branch
Oct 5, 2026
…e-mapping # Conflicts: # provider/a2aprovider/a2a.go # provider/a2aprovider/a2a_test.go
Contributor
API consistency review
Changed Go contractNo exported API changes. The A2A client ( Upstream evidence reviewed
AssessmentThe Go change matches the Python client and Go's own hosting-side
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The client inbound path passed a literal
message.RoleAssistantfor A2A messages (*a2a.Message) and task-status messages, discarding the role carried on the inbound message. So a peer message with the A2A user role was reported as assistant.The hosting side already maps this (
toAgentMessage:agent→ assistant, otherwise user), and the Python client does the same (role="assistant" if msg.role == A2ARole.ROLE_AGENT else "user") — the client-path hardcode was an oversight.Change
agentRolehelper and use it for the*a2a.Messagecase and the two task-status-message cases (streamingTaskStatusUpdateEventandyieldTaskinput-required). Artifacts carry no role, so they stay assistant.Test
TestRunPreservesInboundUserRole: a response*a2a.MessagewithMessageRoleUsernow maps toRoleUser. Fails before (assistant), passes after. The existingMessageRoleAgent → assistantassertion still holds.