Repository navigation
Pass through unmapped Anthropic stop reasons - #1117
Open
PratikDhanave (PratikDhanave) wants to merge 4 commits into
Open
PratikDhanave (PratikDhanave) wants to merge 4 commits into
PratikDhanave (PratikDhanave) wants to merge 4 commits into
Conversation
mapStopReason returned "" for any stop_reason outside its fixed set, so a newer value such as model_context_window_exceeded was reported as no finish reason at all. Pass unmapped reasons through unchanged, matching the Python client (an empty reason still maps to "").
PratikDhanave (PratikDhanave)
requested a review
from a team
as a code owner
September 20, 2026 04:22
github-actions
Bot
added
area:provider
Contributor
There was a problem hiding this comment.
Copilot review overview
🟡 Changes recommended
Update the stale function comment to document the new pass-through behavior.
Get a fresh assessment by requesting another Copilot review.
Review effort: Lite
Findings: 1
Open (1)
What changed in this PR
Updates Anthropic stop-reason handling so unknown non-empty values reach callers unchanged.
Changes:
- Passes through unmapped stop reasons.
- Adds non-streaming and streaming test coverage.
| File | Description |
|---|---|
provider/anthropicprovider/agent.go |
Passes through unknown stop reasons. |
provider/anthropicprovider/agent_test.go |
Tests pass-through behavior in both paths. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Comment on lines
+256
to
+260
| // Pass through stop reasons we don't explicitly map (e.g. a newer | ||
| // value like model_context_window_exceeded) so they still reach the | ||
| // caller instead of being reported as no finish reason, matching the | ||
| // Python client. An empty reason maps to "". | ||
| return string(reason) |
github-actions
Bot
added
kind:code
This comment has been minimized.
This comment has been minimized.
Update the stale comment to reflect that only an empty reason returns ""; unrecognized non-empty reasons are now passed through unchanged.
github-actions
Bot
added
size:medium
This comment has been minimized.
This comment has been minimized.
github-actions
Bot
added
parity-approved
Quim Muntal (qmuntal)
approved these changes
Sep 25, 2026
Member
|
Copilot resolve the merge conflicts in this pull request |
…reason-passthrough # Conflicts: # go.mod # go.sum
github-actions
Bot
added
size:small
This comment has been minimized.
This comment has been minimized.
Quim Muntal (qmuntal)
enabled auto-merge
October 5, 2026 05:29
…reason-passthrough
Contributor
API consistency review
Changed Go contract
Upstream evidence reviewed
AssessmentThe Go change matches Python's passthrough behavior, and the added test case covers the non-streaming and streaming paths. I did not review the .NET adapter. No parity issues found.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
mapStopReason returned
""for anystop_reasonnot in its fixed set, so a value the Anthropic API may add later — e.g.model_context_window_exceeded— was reported as no finish reason instead of reaching the caller. This affects both the non-streaming path and the streaming final update.The Python client passes unmapped reasons through unchanged:
FINISH_REASON_MAP.get(stop_reason, stop_reason), with an explicit docstring that newer API values likemodel_context_window_exceededmust still reach the caller.Change
defaultcase toreturn string(reason). An empty reason still yields"", so the streamingif fr != ""guard is unaffected.StopReasonis a plain string in the anthropic SDK.Test
{"model_context_window_exceeded", "model_context_window_exceeded"}row to the sharedfinishReasonCasestable (runs through bothTestNonStreamingFinishReasonandTestStreamingFinishReason). Fails before (""), passes after.