Skip to content

Stream large -z git output instead of buffering it against the cap #2045

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
tyrielv wants to merge 1 commit into
base: vnext
Choose a base branch
from
Open

Stream large -z git output instead of buffering it against the cap #2045

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 14 additions & 0 deletions GVFS/GVFS.Common/GVFSConstants.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -56,6 +56,20 @@ public static class GitConfig
public const string MountProgress = GVFSPrefix + "mount-progress";
public const bool MountProgressDefault = false;

/* Opt-in switch for NUL-delimited streaming of large "-z" git status/diff output.
* Default false: use the bounded-buffer path with its truncation fail-safes (the proven
* behavior). Set true to stream instead, which processes an arbitrarily large result
* without buffering it. Off by default per the feature-flag convention so the rollout
* infrastructure can enable streaming gradually. */
public const string StreamGitStatusOutput = GVFSPrefix + "stream-git-status-output";
public const bool StreamGitStatusOutputDefault = false;

/* Optional watchdog for the streaming status/diff read: kill the git process if it does
* not finish within this many seconds. Default -1 (infinite / disabled) so a legitimately
* long status on a very large working tree is never killed; operators can opt in. */
public const string GitStatusStreamTimeoutSeconds = GVFSPrefix + "git-status-stream-timeout-seconds";
public const int GitStatusStreamTimeoutSecondsDefault = -1;

public const string MaxHttpConnectionsConfig = GVFSPrefix + "max-http-connections";

public const string PrefetchUseIdx = GVFSPrefix + "prefetch-use-idx";
Expand Down
Loading