Repository navigation
fix: avoid repeated root scans in no-op builds - #64898
Merged
Merged
Conversation
typescript-automation
Bot
added
the
For Uncommitted Bug
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
The focused optimization preserves existing matching behavior, includes targeted tests, and has no identified blocking issues.
No open issues 🎉
What changed in this PR
Addresses #64897 by replacing repeated root scans with direct lookups during no-op build checks.
Changes:
- Adds root-membership lookup and updates virtual-file detection.
- Replaces the supported-extension set with a switch.
- Expands path-matching tests and adds scaling benchmarks.
| File | Description |
|---|---|
tsc/internal/execute/incremental/buildInfo.go |
Adds direct root-membership lookup. |
tsc/internal/execute/build/buildtask.go |
Replaces root scans with path parsing and lookup. |
tsc/internal/execute/build/buildtask_contentmapper_test.go |
Expands correctness tests and adds benchmarks. |
tsc/internal/contentmapper/contentmapper.go |
Simplifies supported-extension checks. |
Review effort: Balanced
Jake Bailey (jakebailey)
approved these changes
Oct 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #64897